Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appservice: Implementation for flex deployment using new api #1714

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

nturinski
Copy link
Member

Flex deployment requirements changed quite a bit. I'll try to break it down as succulently as possible.

  • Remote build should be defaulted. The only runtime where it should be true is python, I believe. I am getting confirmation from the team.
  • Because we shouldn't prompt for remote build anymore (we used to ask the user if they wanted it or not), I removed the customDeployment message logic and reverted it back to how it used to be.
  • Flex deployment API endpoint changed. It required the headers for it to accept the request now as well.
  • Similar to my Functions PR, the payload for the old API version isn't compatible with flex deployment (I need a property that only exists on the new payload). That's why I'm doing the get request
  • For flex deployment, we need to create a storage blob container. The endpoint takes care of it from there. We're able to get connection strings and etc. from the functionAppConfig

@nturinski nturinski requested a review from a team as a code owner March 27, 2024 01:03
MicroFish91
MicroFish91 previously approved these changes Mar 27, 2024
Copy link
Contributor

@MicroFish91 MicroFish91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'll try to break it down as succulently as possible

Can confirm, PR was extra succulent 👍

const client = blobClient.getContainerClient(containerName);
if (!await client.exists()) {
await blobClient.createContainer(containerName, { access: "container" });

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra new line

@nturinski nturinski merged commit ecfe8dc into main Mar 27, 2024
4 checks passed
@nturinski nturinski deleted the appservice/nat/flexDeploy branch March 27, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants