Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency packages #326

Merged
merged 4 commits into from Oct 2, 2023
Merged

Conversation

aarushinair
Copy link
Contributor

@aarushinair aarushinair commented Sep 22, 2023

I have followed the Contribution Guidelines to create a virtual environment and update the library packages

closes #319

@aarushinair
Copy link
Contributor Author

@aarushinair please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

package.json Outdated Show resolved Hide resolved
@karthiknadig karthiknadig self-assigned this Sep 22, 2023
@karthiknadig karthiknadig added debt Technical debt or repo cleanup ghc-osd labels Sep 22, 2023
@karthiknadig
Copy link
Member

Looks like the minimum python for the updated packages in 3.8. @aarushinair can you create a venv using python 3.8. You will also need to update noxfile.py (replace 3.7 with 3.8). before running nox -session update_packages. Ping us on Zoom or Slack for help.

@karthiknadig karthiknadig changed the title Packages updated for OSD Update dependency packages Oct 2, 2023
Copy link
Member

@eleanorjboyd eleanorjboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the section on the PR for GHC23?

@karthiknadig
Copy link
Member

@eleanorjboyd I removed that file.

@karthiknadig karthiknadig enabled auto-merge (squash) October 2, 2023 20:23
karthiknadig
karthiknadig previously approved these changes Oct 2, 2023
@karthiknadig karthiknadig enabled auto-merge (squash) October 2, 2023 20:47
@karthiknadig karthiknadig merged commit bf4b447 into microsoft:main Oct 2, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical debt or repo cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update library packages for the extension
5 participants