Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Commit

Permalink
Now we send all the telemetry properties of the start-up timings even…
Browse files Browse the repository at this point in the history
…t in sentence case
  • Loading branch information
Diego Geffner committed Mar 22, 2018
1 parent f4e5513 commit 40bb29f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/chrome/chromeDebugSession.ts
Expand Up @@ -125,7 +125,7 @@ export class ChromeDebugSession extends LoggingDebugSession implements IObservab
*/
protected dispatchRequest(request: DebugProtocol.Request): void {
// We want the request to be non-blocking, so we won't await for reportTelemetry
this.reportTelemetry(`clientRequest/${request.command}`, { requestType: request.type }, async (reportFailure) => {
this.reportTelemetry(`ClientRequest/${request.command}`, { requestType: request.type }, async (reportFailure) => {
const response: DebugProtocol.Response = new Response(request);
try {
logger.verbose(`From client: ${request.command}(${JSON.stringify(request.arguments) })`);
Expand Down Expand Up @@ -231,7 +231,7 @@ export class ChromeDebugSession extends LoggingDebugSession implements IObservab
public reportTimingsWhileStartingUpIfNeeded(requestedContentWasDetected: boolean | 'timeout'): void {
if (!this.haveTimingsWhileStartingUpBeenReported) {
const report = this.reporter.generateReport();
const telemetryData = { requestedContentWasDetected: requestedContentWasDetected.toString() };
const telemetryData = { RequestedContentWasDetected: requestedContentWasDetected.toString() };
for (const reportProperty in report) {
telemetryData[reportProperty] = JSON.stringify(report[reportProperty]);
}
Expand Down
2 changes: 1 addition & 1 deletion src/executionTimingsReporter.ts
Expand Up @@ -136,7 +136,7 @@ export class ExecutionTimingsReporter {
public generateReport(): {[stepName: string]: [number] | number} {
this.recordPreviousStepAndConfigureNewStep('AfterLastStep');
this._subscriptionManager.removeAll(); // Remove all subscriptions so we don't get any new events
return Object.assign({}, { steps: this._stepsList, all: calculateElapsedTime(this._allStartTime) }, this._requestProperties, this._eventsExecutionTimesInMilliseconds);
return Object.assign({}, { Steps: this._stepsList, All: calculateElapsedTime(this._allStartTime) }, this._requestProperties, this._eventsExecutionTimesInMilliseconds);
}

public recordRequestCompleted(requestName: string, startTime: number, timeTakenInMilliseconds: number): void {
Expand Down

0 comments on commit 40bb29f

Please sign in to comment.