-
Notifications
You must be signed in to change notification settings - Fork 119
Fix break-on-load to make breakpoints on attach work #332
Conversation
@rakatyal PTAL |
Is this still valid? Are you going to review it @rakatyal? |
@roblourens: Yes I believe this is still valid but we are not planning to ship this at the moment. I will review this soon. |
@roblourens @rakatyal We are planning on using this PR for VS 16. Could you please review it now? |
@rakatyal are you going to review this? |
@roblourens: Yes I will do this today. Apologies for missing this earlier. |
suite('break-on-load', () => { | ||
test('is active when the parameter is specified and we are launching', async () => { | ||
await chromeDebugAdapter.launch({breakOnLoadStrategy: 'regex'}); | ||
assert(chromeDebugAdapter.breakOnLoadActive, 'Break on load should we active if we pass the proper parameter and we are attaching'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should "be" active
|
||
test('is active when the parameter is specified and we are attaching', async () => { | ||
await chromeDebugAdapter.attach({breakOnLoadStrategy: 'regex', port: ATTACH_SUCCESS_PORT}); | ||
assert(chromeDebugAdapter.breakOnLoadActive, 'Break on load should we active if we pass the proper parameter and we are attaching'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should "be" active
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and for including so many tests!
This as final bug-fixes. At this moment we are using this change as a temporary-workaround to fix the NTVS unit tests