This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Update logging mechanism to not log sources #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you file an issue and include more details about what you are trying to do and why? Even though this is a relatively simple change please don't make me or other contributors reverse engineer the intent of this from the diff. |
roblourens
reviewed
Sep 19, 2018
| public sendResponse(response: DebugProtocol.Response): void { | ||
| const originalLogVerbose = logger.verbose; | ||
| try { | ||
| logger.verbose = textToLog => { |
There was a problem hiding this comment.
Hm, what would be a better way to allow customizing the logged message?
Maybe the logger could call a method on DebugSession that formats the string for logging, and it can be overridden here?
There was a problem hiding this comment.
I filed microsoft/vscode-debugadapter-node#201 on myself to follow up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update logging mechanism to not log sources