IntelliSense does not work for files not in folder with a CMake configured project

[robotdad]

Type: LanguageService

Describe the bug

• OS and Version: Windows 10
• VS Code Version: 1.48.2
• C/C++ Extension Version: .29
• Other extensions you installed (and if the issue persists after disabling them): Lots
• Does this issue involve using SSH remote to run the extension on a remote machine?: No
• A clear and concise description of what the bug is, including information about the workspace (i.e. is the workspace a single project or multiple projects, size of the project, etc).

Steps to reproduce

1. Clone https://github.com/azure-rtos/getting-started with --recursive
2. Open the subfolder MXChip/AZ3166/
3. Configure settings for CMake
   {
   "cmake.configureArgs": [
   "-DCMAKE_TOOLCHAIN_FILE=../../cmake/arm-gcc-cortex-m4.cmake"
   ],
   "C_Cpp.default.configurationProvider": "ms-vscode.cmake-tools",
   "cortex-debug.openocdPath": "C:/tools/OpenOCD/bin/openocd.exe"
   }
4. Open main.c

Expected behavior

Correct IntelliSense, especially as project can build. The files that are flagged as not found are not in the project folder but are configured for the CMake build.

Logs

-------- Diagnostics - 9/3/2020, 3:31:15 PM
Version: 0.29.0
Current Configuration:
{
    "name": "Win32",
    "includePath": [
        "${workspaceFolder}/**"
    ],
    "defines": [
        "_DEBUG",
        "UNICODE",
        "_UNICODE"
    ],
    "windowsSdkVersion": "10.0.18362.0",
    "compilerPath": "C:/Program Files (x86)/Microsoft Visual Studio/2019/Preview/VC/Tools/MSVC/14.28.29231/bin/Hostx64/x64/cl.exe",
    "cStandard": "c11",
    "cppStandard": "c++17",
    "intelliSenseMode": "msvc-x64",
    "compilerArgs": [],
    "configurationProvider": "ms-vscode.cmake-tools",
    "browse": {
        "path": [
            "${workspaceFolder}/**"
        ],
        "limitSymbolsToIncludedHeaders": true
    }
}
Custom browse configuration: 
{
    "browsePath": []
}
Translation Unit Mappings:
[ C:\source\scratch\getting-started\MXChip\AZ3166\app\main.c ]:
    C:\SOURCE\SCRATCH\GETTING-STARTED\MXCHIP\AZ3166\APP\MAIN.C
Translation Unit Configurations:
[ C:\source\scratch\getting-started\MXChip\AZ3166\app\main.c ]:
    Process ID: 14476
    Memory Usage: 12 MB
    Compiler Path: C:/Program Files (x86)/Microsoft Visual Studio/2019/Preview/VC/Tools/MSVC/14.28.29231/bin/Hostx64/x64/cl.exe
    Includes:
        C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2019\PREVIEW\VC\TOOLS\MSVC\14.28.29231\INCLUDE
        C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2019\PREVIEW\VC\TOOLS\MSVC\14.28.29231\ATLMFC\INCLUDE
        C:\PROGRAM FILES (X86)\WINDOWS KITS\10\INCLUDE\10.0.18362.0\UM
        C:\PROGRAM FILES (X86)\WINDOWS KITS\10\INCLUDE\10.0.18362.0\UCRT
        C:\PROGRAM FILES (X86)\WINDOWS KITS\10\INCLUDE\10.0.18362.0\SHARED
        C:\PROGRAM FILES (X86)\WINDOWS KITS\10\INCLUDE\10.0.18362.0\WINRT
        C:\PROGRAM FILES (X86)\WINDOWS KITS\10\INCLUDE\10.0.18362.0\CPPWINRT
        C:\SOURCE\SCRATCH\GETTING-STARTED\MXCHIP\AZ3166\LIB\STM32CUBEF4\DRIVERS\STM32F4XX_HAL_DRIVER\INC
        C:\SOURCE\SCRATCH\GETTING-STARTED\MXCHIP\AZ3166\LIB\STM32CUBEF4\CONFIG
        C:\SOURCE\SCRATCH\GETTING-STARTED\MXCHIP\AZ3166\LIB\STM32CUBEF4\DRIVERS\STM32F4XX_HAL_DRIVER\INC\LEGACY
        C:\SOURCE\SCRATCH\GETTING-STARTED\MXCHIP\AZ3166\LIB\STM32CUBEF4\DRIVERS\CMSIS\DEVICE\ST\STM32F4XX\INCLUDE
        C:\SOURCE\SCRATCH\GETTING-STARTED\MXCHIP\AZ3166\LIB\STM32CUBEF4\DRIVERS\CMSIS\INCLUDE
    Defines:
        _DEBUG
        UNICODE
        _UNICODE
    Standard Version: c11
    IntelliSense Mode: msvc-x64
Total Memory Usage: 12 MB

Screenshots

Additional context

[sean-mcmanus]

Your logs indicate the CMake Tools extension is sending us no configuration data -- blank custom browse configuration and Custom configurations section. Is the CMake Tools extension properly configured?

[robotdad]

The project builds with the CMake extension. Is there some diagnostic info I can collect from it that would help?

[sean-mcmanus]

Configuration works for me when I use the arm-none-eabi 6.3.1 kit. What kit are you using and how do I install it?

[robotdad]

Are you using the toolchain file as shown above? I don't have a kit specified, it didn't recognize my arm-gcc installation.

[sean-mcmanus]

Yeah, I have "cmake.configureArgs": [ "-DCMAKE_TOOLCHAIN_FILE=../../cmake/arm-gcc-cortex-m4.cmake" ] set. Looks like I'm getting a cmake build error though. I might not have the required build tools installed.

[sean-mcmanus]

vswhere.exe isn't able to locate my gcc_arm for some reason (16.8 Preview 3)

[sean-mcmanus]

I added -prerelease to the call to vswhere to fix the build issue and I reproed the bug.

CMake Tools isn't sending the configuration info.

[davepiar]

We're facing the same issue in our company, as we work with cmake projects in a multi-root workspace environment. Do you have any plans to fix it?

[sean-mcmanus]

@thepineda It isn't currently on our schedule to fix, but the CMake Tools extension is open source so you could contribute a fix.

[bobbrow]

@robotdad, @aleun, is this something your team would like to take ownership of? We should discuss in our next sync.

[allo-]

Is this a regression?
Currently I have the same problem, header files outside of the project root are not found automatically even when the cmake build works correctly and I did not touch the code for a few months (and it worked before).
It did not work with the code folder as it was untouched and reconfiguring in different ways does not resolve the problem either.

[gcampbell-msft]

@robotdad Have you hit this issue recently? I just attempted the repro steps and everything seems to work as expected.

I should mention that to reproduce this I cloned a brand new project and started completely from scratch (including vcpkg).

@sean-mcmanus Were you ever able to repro the issue or did it behave as expected for you as well?

[sean-mcmanus]

@gcampbell-msft According to my comment 3 years ago at #1425 (comment) I was reproing the issue.

[gcampbell-msft]

Based on the age of this issue, and the fact that I've tried the repro steps and the issue seems to be resolved, I'm closing the issue.

FYI @sean-mcmanus @robotdad. @robotdad Please open another issue if this continues to be an issue for you. Thanks!