Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CMake Presets v6 #2871

Closed
mathisloge opened this issue Nov 24, 2022 · 7 comments
Closed

Add support for CMake Presets v6 #2871

mathisloge opened this issue Nov 24, 2022 · 7 comments
Assignees
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets fixed (release pending) fixed in pre-release and is pending official release
Projects
Milestone

Comments

@mathisloge
Copy link

mathisloge commented Nov 24, 2022

Brief Issue Summary

With CMake 3.25 there are now package and workflow presets.
It would be good as a first step to just accept them.

https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response

@bobbrow bobbrow added this to the 1.14 milestone Nov 28, 2022
@bobbrow bobbrow added this to Triage in 1.14 via automation Nov 28, 2022
@elahehrashedi
Copy link
Contributor

Thank you for this feature request. We will add the support in the future.

@Kuxe
Copy link

Kuxe commented Dec 2, 2022

Just having

"workflowPresets": [
  {
    [...]
  }
}

breaks vscode-cmake-tools - it can't find configure and build presets anymore.

The most current documentation is misleading

The CMake Tools extension supports version 2 or later for the CMakePresets.json and CMakeUserPresets.json files.

since version features introduced in version 6 do not work.

@nolange
Copy link

nolange commented Dec 12, 2022

breaks vscode-cmake-tools - it can't find configure and build presets anymore.

This annoys me too, can we get a quick fix ignoring unknown properties please?
Kinda like a less strict mode if the presets version is higher than the last one supported.

@bobbrow bobbrow moved this from Triage to To Do in 1.14 Dec 15, 2022
@vdilecce
Copy link

breaks vscode-cmake-tools - it can't find configure and build presets anymore.

This annoys me too, can we get a quick fix ignoring unknown properties please? Kinda like a less strict mode if the presets version is higher than the last one supported.

Having a CMakePresets.json file with unknown properties (e.g. higher version) breaking the extension behavior is indeed annoying. Currently it's either presets v6 new features or a proper VS Code developing experience.

If the support for presets version 6 cannot be included in 1.13 (the release of which I assume is not too distant in the future), I also would be happy with a (quick?) fix to ignore what's unknown in CMakePresets.json.

@bobbrow bobbrow added Feature: presets enhancement an enhancement to the product that is either not present or an improvement to an existing feature labels Jan 13, 2023
@bobbrow
Copy link
Member

bobbrow commented Jan 13, 2023

If the support for presets version 6 cannot be included in 1.13 (the release of which I assume is not too distant in the future), I also would be happy with a (quick?) fix to ignore what's unknown in CMakePresets.json.

Unfortunately, presets version 6 will not be in 1.13. But thanks for the reminder on ignoring unknown properties. I added a new setting to ignore unknown properties/macros for unsupported versions in this PR which we will take for 1.13 #2945. cmake.allowUnsupportedPresetsVersions

@vdilecce
Copy link

I added a new setting to ignore unknown properties/macros for unsupported versions in this PR which we will take for 1.13 #2945. cmake.allowUnsupportedPresetsVersions

Thank you for your quick feedback, much appreciated!

@bobbrow bobbrow changed the title Add support for package and workflow presets Add support for CMake Presets v6 Feb 9, 2023
@bobbrow bobbrow removed this from To Do in 1.14 Feb 9, 2023
@bobbrow bobbrow added this to Triage in 1.15 via automation Feb 9, 2023
@bobbrow bobbrow modified the milestones: 1.14, On Deck Feb 9, 2023
@benmcmorran benmcmorran moved this from Triage to To do in 1.15 May 22, 2023
@benmcmorran benmcmorran modified the milestones: On Deck, 1.15 May 22, 2023
@benmcmorran benmcmorran assigned benmcmorran and unassigned nasinlock May 22, 2023
@benmcmorran benmcmorran modified the milestones: 1.15, 1.16 Aug 10, 2023
@benmcmorran benmcmorran removed this from To do in 1.15 Aug 10, 2023
@benmcmorran benmcmorran added this to Triage in 1.16 via automation Aug 10, 2023
@benmcmorran benmcmorran assigned andreeis and unassigned benmcmorran Sep 7, 2023
@benmcmorran benmcmorran modified the milestones: 1.16, 1.17 Oct 4, 2023
@gcampbell-msft gcampbell-msft added this to Triage in 1.17 via automation Nov 20, 2023
@gcampbell-msft gcampbell-msft removed this from Triage in 1.16 Nov 20, 2023
@sinemakinci1
Copy link
Contributor

Also add support for v7 and v8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets fixed (release pending) fixed in pre-release and is pending official release
Projects
Status: Completed
1.17
Done
Development

No branches or pull requests