Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for $penv{} in include in CMake(User)Presets.json #3310

Closed
jogerh opened this issue Aug 21, 2023 · 3 comments
Closed

Support for $penv{} in include in CMake(User)Presets.json #3310

jogerh opened this issue Aug 21, 2023 · 3 comments
Assignees
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets fixed (release pending) fixed in pre-release and is pending official release IMPORTANT
Projects
Milestone

Comments

@jogerh
Copy link

jogerh commented Aug 21, 2023

Brief Issue Summary

https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html#includes describes that $penv{} can be used in include statements. This can be quite useful, particularly for centralizing user settings. One useful way of using this can be:

{ "version": 7, "include": [ "$penv{USERPROFILE}\MyPresets.json", ] }

This works with CMake, but it seems like it does not play well when configuring from VSCode with CMake Tools.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response

@gcampbell-msft
Copy link
Collaborator

@jogerh Could you provide some information about how it doesn't seem to play well?

A couple of things that could be helpful for us to have are the following:

  1. CMake Tools Diagnostics
  2. Repro project that shows the issue. Detail what you are expecting versus what happens.

Thanks!

@gcampbell-msft gcampbell-msft added bug a bug in the product Feature: presets more info needed More info is needed from the community for us to properly triage and investigate. labels Aug 23, 2023
@gcampbell-msft gcampbell-msft added this to Triage in 1.16 via automation Aug 23, 2023
@gcampbell-msft gcampbell-msft added this to the 1.16 milestone Aug 23, 2023
@microsoft microsoft deleted a comment from github-actions bot Sep 7, 2023
@benmcmorran benmcmorran self-assigned this Oct 10, 2023
@benmcmorran benmcmorran moved this from Triage to To do in 1.16 Oct 10, 2023
@benmcmorran benmcmorran removed the more info needed More info is needed from the community for us to properly triage and investigate. label Oct 10, 2023
@benmcmorran benmcmorran added enhancement an enhancement to the product that is either not present or an improvement to an existing feature and removed bug a bug in the product labels Oct 10, 2023
@benmcmorran
Copy link
Member

Relabeling as an enhancement because this is asking for a part of CMakePresets v7 support, which we don't yet formally support.

@benmcmorran benmcmorran added the fixed (release pending) fixed in pre-release and is pending official release label Oct 16, 2023
Copy link

🎉 This issue has now been fixed and is now available in the latest release! 🎉

1.16 automation moved this from To do to Done Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets fixed (release pending) fixed in pre-release and is pending official release IMPORTANT
Projects
No open projects
1.16
Done
Development

No branches or pull requests

4 participants