Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support $penv{} in include paths #3377

Merged
merged 3 commits into from Oct 12, 2023
Merged

Support $penv{} in include paths #3377

merged 3 commits into from Oct 12, 2023

Conversation

benmcmorran
Copy link
Member

Addresses #3310

This ended up as more of a new feature than a bug fix. We don't formally support all of CMakePresets v6 or v7 right now, but this is a simple change to enable the include path part of the v7 changes.

gcampbell-msft
gcampbell-msft previously approved these changes Oct 11, 2023
Copy link
Collaborator

@gcampbell-msft gcampbell-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit comment, other than that, everything looks good.

src/presetsController.ts Outdated Show resolved Hide resolved
@benmcmorran benmcmorran enabled auto-merge (squash) October 11, 2023 18:05
@benmcmorran benmcmorran merged commit 95a17bd into main Oct 12, 2023
4 checks passed
@benmcmorran benmcmorran deleted the dev/bemcmorr/3310 branch October 12, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants