Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow a way to run jobs in parallel #3271

Merged
merged 10 commits into from
Aug 1, 2023
Merged

Conversation

snehara99
Copy link
Contributor

If you set cmake.ctest.allowParallelJobs to true, then jobs can run in parallel. However, this also means that the result output may be garbled (no functional impact).

@snehara99 snehara99 self-assigned this Jul 31, 2023
@snehara99 snehara99 linked an issue Jul 31, 2023 that may be closed by this pull request
@snehara99
Copy link
Contributor Author

I tested this on bullet3 and it appeared to work properly, but if someone can help with more thorough testing that would be nice because I am still learning the extents of ctest

@gcampbell-msft
Copy link
Collaborator

I tested this on bullet3 and it appeared to work properly, but if someone can help with more thorough testing that would be nice because I am still learning the extents of ctest

Could you paste in a screenshot of what the new functionality looks like? Or if it's easier to ping that offline that's fine. The code looks fine, especially since it's based on a user opt-in setting. 👍

gcampbell-msft
gcampbell-msft previously approved these changes Aug 1, 2023
@gcampbell-msft gcampbell-msft self-requested a review August 1, 2023 12:15
@gcampbell-msft gcampbell-msft dismissed their stale review August 1, 2023 12:15

Leaving time for testing.

gcampbell-msft
gcampbell-msft previously approved these changes Aug 1, 2023
benmcmorran
benmcmorran previously approved these changes Aug 1, 2023
Copy link
Member

@benmcmorran benmcmorran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs a doc update to document the new setting.

CHANGELOG.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@snehara99
Copy link
Contributor Author

I tested this on bullet3 and it appeared to work properly, but if someone can help with more thorough testing that would be nice because I am still learning the extents of ctest

Could you paste in a screenshot of what the new functionality looks like? Or if it's easier to ping that offline that's fine. The code looks fine, especially since it's based on a user opt-in setting. 👍

This is with the setting turned off (it keeps repeating for more tests than I captured on the screenshot):
image

This is with the setting turned on:
image

@snehara99 snehara99 merged commit aa21395 into main Aug 1, 2023
4 checks passed
@snehara99 snehara99 deleted the dev/snehara/allow-parallel-tests branch August 1, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run CTest tests in parallel
4 participants