fixed some inherit bugs for statusbar visibility #3579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snehara99
requested review from
lukka,
andreeis,
gcampbell-msft and
sinemakinci1
gcampbell-msft
approved these changes
Feb 9, 2024
| @@ -70,13 +70,11 @@ export interface AdvancedOptionConfig { | |||
| statusBarLength?: number; | |||
| }; | |||
| packagePreset?: { | |||
| projectStatusVisibility?: ProjectStatusOptionVisibility; | |||
There was a problem hiding this comment.
Why is this removed?
There was a problem hiding this comment.
the presets are the children of the main dropdown node on the sidebar. Only the parent node should be able to be set visible or not (cpack and workflow)
There was a problem hiding this comment.
also there wasn't an equivalent setting in package.json
sinemakinci1
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the default settings to actually get the
inheritDefaultvalues. Defaults in nested settings like these need to be put at the top level to be recognized. Also removed the config.ts option for project status visibility for the new presets since only the top level node on the sidebar tree should be configurable.