Add onSelectedConfigurationChanged api
#3671
Conversation
|
@microsoft-github-policy-service agree |
OrkunTokdemir
force-pushed
the
orkun_on_selected_kit_changed_27_03_2024
branch
2 times, most recently
from
d36bd52
to
4ad0b5c
Compare
OrkunTokdemir
force-pushed
the
orkun_on_selected_kit_changed_27_03_2024
branch
from
4ad0b5c
to
8089435
Compare
|
@gcampbell-msft Can you please take a look when you're available? |
|
@OrkunTokdemir We'd be happy to take this change, but we'd like to have the respective change in the vscode-cmake-tool-api if possible. Could you make this change as well? We're happy to help with this if needed! |
This commit extends microsoft/vscode-cmake-tools#3671
This commit extends microsoft/vscode-cmake-tools#3671
This commit extends microsoft/vscode-cmake-tools#3671
@gcampbell-msft Thank you. I created a PR in that repo. |
This commit extends microsoft/vscode-cmake-tools#3671
|
@OrkunTokdemir Could you test with the most recent commit? This should update the package.json dependency from the vscode-cmake-tools npm package, and should be fully functional. Thanks! |
gcampbell-msft
requested review from
bobbrow,
elizabethmorrow,
qarni and
moyo1997
When `notifyOnSelectedConfigurationChanged()` is executed before `setFolderActiveKit()`, `cmake.buildKit` returns the previous selected kit. That's why `notifyOnSelectedConfigurationChanged()` should run after `setFolderActiveKit()`.
@gcampbell-msft Thank you for updating the dependencies. I tested some more detailed cases. All of them look fine. Found a little problem and fixed it with 28ef5b5 LGTM 🚀 |
gcampbell-msft
changed the title
onSelectedKitChanged apionSelectedConfigurationChanged api
Since microsoft/vscode-cmake-tools#3671 is merged, we can use CMake api to update the Qt extension internals. * Add CMake api infrastructure * Remove the workaround for the case when the kit change is not detectable. Change-Id: I382fd1586893da32057de43ce173feace921d0a8 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
I added a new event api for the select kit change. It is needed for our extension to detect it. I guess I should also prepare a pull request for https://github.com/microsoft/vscode-cmake-tools-api.