Add setting for deleting whole build dir when clean configuring #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcampbell-msft
requested changes
May 28, 2024
snehara99
previously approved these changes
May 31, 2024
gcampbell-msft
previously approved these changes
Jun 3, 2024
gcampbell-msft
approved these changes
Jun 24, 2024
gcampbell-msft
added a commit
that referenced
this pull request
Jul 3, 2024
* reversed order of creating workspace browse configurations (#3758) * reversed order of creating workspace browse configurations * updated tests * minimized change by only reversing fileGroups, and reverted tests * Add clarity in the build log when builds are out of source (#3778) * Add chesscc to the allow-list of compilers. (#3777) Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com> * Fix doubling of cpack args passed by package preset (#3766) * Remove unnecessary logging about string expansion (#3761) * Remove unnecessary logging about string expansion * Fix typo in var name --------- Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com> * Fix UI for settings override of package presets (#3770) * Fix UI for settings override of package presets * Fix linter errors * Skip full configure on variant change for multi-config generators (#3763) * Don't fully configure after variant change for multi-config generators. Only change parameter for build and refresh IntelliSense. * Added missing return on 'if else' * Removed unnecessary log. No previous configure message was printed before it.' * Run clean-configure when workflow has different configure preset than project (#3768) * Let cmake.configureArgs overwrite the default cmake args (#3762) Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com> * Handle "~" in binaryDir path (#3764) * File system APIs don't recognize ~ in paths and because of this the extension cannot properly interpret cmake file-api jsons to list targets. * Fix path typo --------- Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com> * Warning when VS installation instance not found (#3775) * Add warning about not found VS installation instance and suggestion to re-scan kits, at the request of developers in the community. * Fix linter errors --------- Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com> * Fix GitHub 3602, mention --build-config even for default test preset (#3779) * Better validations that validate before running. (#3774) * initial commit * add better values * check notice and changelog before release version * Update kits-variants doc with unsupported commands that are specific for presets (#3784) Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com> * colorization support in pre-release (#3794) * colorization support in pre-release * update changelog * Sort CMakeLists.txt by depth (#3789) * Sort CMakeLists.txt by depth * Add changes to CHANGELOG.md --------- Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com> * Fixed string parameters and added clarification to the log message (#3787) * Localization - Translated Strings (#3753) Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com> * fix schema field in v8 schema (#3809) * Add check that limits when we -R a regex of all tests (#3814) * fix ctest * only try to be smart about this in the test explorer entry points * updating comment * add try catch in debug createRunProfile * Localization - Translated Strings (#3816) * Update CHANGELOG.md * update localization for project status view and quick pick (#3810) * fix issue with test results not found (#3823) * update braces dependency (#3839) * Fixes #3725 - user presets not read correctly (#3826) * get all presets to show in inherit * if new configure preset inherits from a user preset add to the user presets file * todo: finish update for different types of presets * checks for configure inherit and inherit. todo - check workflow * cleanup + mark as isUserPreset * undo use isuserpreset field * cleanup and changelog * cleanup * rename interface * update workflow preset to not extend preset + refactor inheritsfromuserpreset func * remove preset class fields from workflow preset * more workflow preset cleanup * Fixes #3811 - checks for cmake.exe again if it wasnt present the previous time (#3840) checks for exe again if it wasn't present the previous time * Tree view for tests using test suite delimiter (#3759) * Implement treeview for tests using test suite delimiter * Support regular expressions for delimiters * Improve UI string * Improve UI string * Address CR comments * Fix spacing * make sure to pass entry point through --------- Co-authored-by: Garrett Campbell <gcampbell@microsoft.com> Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com> * Update telemetry API to latest version. (#3843) * presets + cmake.buildToolArgs: make sure `--` is added in all cases (#3755) * presets + cmake.buildToolArgs: make sure `--` is added in all cases Fixes #3754. This issue was introduced in #3537 (cmake.buildToolsArgs was ignored for presets before). * Update changelog --------- Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com> * Update CHANGELOG.md * Fixes #3140 - Test log unavailable (#3752) * Using \r\n as line ending Seems like \r\n is the line ending characters in the Test Output even on systems different from win32 * Specify the test item in the call to appendOutput Doing so allows to have the output of the test to be printed out in the left part of the "TEST RESULTS" pane when clicking on the desired test in the right part of the same pane. Before this change we get "The test case did not report any output" * Adds location information in the call to appendOutput. The test object may have uri and ranges that can help localization * Adds entry in the CHANGELOG --------- Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com> * Upgrade cmake_minimum_required version 3.0.0 -> 3.5.0 (#3805) * Update cmakeProject.ts Upgrade cmake_minimum_required version 3.0.0 -> 3.5.0 * Update CHANGELOG.md --------- Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com> * Add setting for deleting whole build dir when clean configuring (#3783) * Add setting for deleting whole build dir when clean configuring * Remove unnecessary tag in new setting in package.json * Add changelog entry. Remove unnecessary | null from new boolean setting. --------- Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com> * log error for cmake exe not found (#3847) * Fixed how we use our '--warn-unused-cli' flag (#3860) * '--warn-unused-cli' is now used to remove the default '--no-warn-unused-cli' command instead of removing and also adding itself to the arguments * only removed '--warn--unused-cli' instead of all initial_common_flgs * Set useCMakePresets context after quick start (#3853) update active proj to set userpreset context * remove from pre-release (#3861) * clean configures when platform differs between old and new selected kit (#3859) * clean configures when only platform changes between kits * updated changelog * check toolset too * changelog * update changelog * add rel to branches (#3867) --------- Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com> Co-authored-by: Andreea Isac <48239328+andreeis@users.noreply.github.com> Co-authored-by: Joan Marcè i Igual <jmigual@users.noreply.github.com> Co-authored-by: CSIGS@microsoft.com <csigs@users.noreply.github.com> Co-authored-by: Fatima Qarni <fatimaqarni@microsoft.com> Co-authored-by: vinocher-bc <160914867+vinocher-bc@users.noreply.github.com> Co-authored-by: Bob Brown <bobbrow@users.noreply.github.com> Co-authored-by: Jeremie Allard <jeremie.allard@insimo.fr> Co-authored-by: hippo91 <guillaume.peillex@gmail.com> Co-authored-by: LiuZengqiang <74355935+LiuZengqiang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug #3515.
At the community request, add a new boolean setting for deleting the whole build directory when configuring-clean (as opposed to deleting only the cache file and a smaller subfolder under the structure of the build dir).