implement #2521 by adding output channel argument #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
@gcampbell-msft any update on this? It's been months and it's not being merged? |
|
@stepeos Thanks for the ping, we've had it on our backlog for awhile and just haven't gotten to it, thanks for the reminder. |
|
@stepeos Overall it looks good, but could you add a CHANGELOG update? |
package.json
Outdated
| @@ -3512,12 +3512,14 @@ | |||
| "enum": [ | |||
| "focus", | |||
| "always", | |||
| "never" | |||
| "never", | |||
| "on error" | |||
There was a problem hiding this comment.
I think I'd rather have this enum value simply be error
gcampbell-msft
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Just a couple of small nit changes, otherwise I appreciate the contribution and it's a good idea! Sorry for the delay in reviewing.
Also, could you please make a CHANGELOG update as well? Feel free to give yourself credit as other OSS contributors have in the changelog before.
gcampbell-msft
previously approved these changes
Jul 11, 2024
gcampbell-msft
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, this is my first ts PR, so be adivesd. I really wanted this functionality so I'll throw the ball.
This change addresses item #2521
The changes include:
an option to keep the output channel hidden unless there is a build or configuration error
The following changes are proposed:
showChannelof the logging output channel"on error"option can be triggeredThe purpose of this change
Building and configuring a project should not divert the programmers focus from the code when building. The user actually only needs to see the output window if an error occurs.
Other Notes/Information
I see no other way than calling
showChanneltwice since option"always"expects the showChannel to pop before configuring starts while"on error"expects it after.