Mark all tests as 'notrun' in case of build failure when running CTest #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morozov-5F
changed the title
…n-error-during-test-run
andreeis
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Looks good.
One thought for later: maybe mark the tests as not run before the build starts, so that during a long build the CTest button would not reflect the previously passed state. I didn't check what would be needed to be done after the successful build, but if it doesn't happen automatically the 'not run' state of the tests can be reverted back to a run state or eventually a pass state.
|
Good idea! Propose to make this change in a separate PR. |
…n-error-during-test-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes CTest visible behaviour
The following changes are proposed:
The purpose of this change
It can be confusing sometimes that tests are marked as passed when I add new test case into the test code which exercises not yet implemented behaviour. This thing can occur when doing a TDD -- most of the time you end up adding a non-exisiting (yet) function call to the test code and automatically running tests to make sure everything fails as expected. Even though it fails VSCode UI shows that tests are "all green" and it may be confusing.