Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlineChat Can't Be Closed #391

Closed
tuduongquyet opened this issue Sep 12, 2023 · 12 comments
Closed

InlineChat Can't Be Closed #391

tuduongquyet opened this issue Sep 12, 2023 · 12 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug inline-chat Inline editor chat session UI verified Verification succeeded

Comments

@tuduongquyet
Copy link

Version: 1.81.1
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:20:33.924Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin x64 19.6.0

Steps to Reproduce:

  1. Open VS Code.
  2. Create a new file.
  3. Write some code in the file.
  4. Right-click on the code and select "Copilot -> Start Code Chat."
  5. The floating Code Chat window appears.
  6. Attempt to initiate a chat with the message "Porting to Python."
  7. Close the Code Chat window.
  8. Create a new file.
  9. Notice that the Code Chat window persists, allowing text input but preventing execution or closure (Escape key doesn't work).
  10. If a new file is created, the same issue occurs.
  11. To resolve this issue, reopen VS Code.
@github-actions github-actions bot added the triage-needed Issues needing to be assigned to the prospective feature owner label Sep 12, 2023
@rchiodo
Copy link

rchiodo commented Sep 12, 2023

I hit this same problem. Here's what it looks like:

image

The overlay never goes away.

@ulugbekna ulugbekna removed the triage-needed Issues needing to be assigned to the prospective feature owner label Sep 12, 2023
@ulugbekna ulugbekna assigned jrieken and unassigned ulugbekna Sep 12, 2023
@ulugbekna
Copy link
Contributor

Hi,

Thanks for filing this issue!

Could you update to latest VS Code 1.82 and see if you can reproduce?

@jrieken jrieken added the info-needed Issue requires more information from poster label Sep 12, 2023
@jrieken
Copy link
Member

jrieken commented Sep 12, 2023

@rchiodo Are you also using Version: 1.81.1

@rchiodo
Copy link

rchiodo commented Sep 12, 2023

I'm using 1.83:

Version: 1.83.0-insider (user setup)
Commit: b257cce9e7fa2d5f475ac16c15b40280d0b97957
Date: 2023-09-08T17:37:16.115Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.22621

@jrieken
Copy link
Member

jrieken commented Sep 12, 2023

@tuduongquyet @rchiodo We cannot diagnose issues from screen capture. For that we have log files and the dev tool console output (F1 > Show Logs > Window and F1 > Toggle Developer Tools > Console). Please attach the readings of those

@rchiodo
Copy link

rchiodo commented Sep 12, 2023

I can't figure out how to save console logs anymore. Right clicking doesn't seem to work. Here's a screenshot of the log:

image

Repro steps are pretty consistent though:

  1. Open chat window from source file
  2. Ask it to do something
  3. Close the source file after it gives you a diff editor
  4. Reopen the source file (I opened it using goto def)
  5. Overlay appears again and can't be dismissed

@tuduongquyet
Copy link
Author

Hi,

Thanks for filing this issue!

Could you update to latest VS Code 1.82 and see if you can reproduce?

The same issue occurs at the latest version

@jrieken
Copy link
Member

jrieken commented Sep 12, 2023

No luck for me. Please enable trace logging and share the logs. Also the source from which you have started.

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug inline-chat Inline editor chat session UI and removed info-needed Issue requires more information from poster labels Sep 12, 2023
@jrieken
Copy link
Member

jrieken commented Sep 12, 2023

Ok, I could reproduce. The steps from #391 (comment) are good, but make sure to not enable auto-save

@jrieken
Copy link
Member

jrieken commented Sep 12, 2023

stacktrace running out of sources

ERR startLineNumber 31 cannot be after endLineNumberExclusive 28: Error: startLineNumber 31 cannot be after endLineNumberExclusive 28
    at new LineRange (vscode-file://vscode-app/Users/jrieken/Code/_collab/vscode2/out/vs/editor/common/core/lineRange.js:60:23)
    at invertLineRange (vscode-file://vscode-app/Users/jrieken/Code/_collab/vscode2/out/vs/workbench/contrib/inlineChat/browser/utils.js:15:21)
    at InlineChatLivePreviewWidget._computeHiddenRanges (vscode-file://vscode-app/Users/jrieken/Code/_collab/vscode2/out/vs/workbench/contrib/inlineChat/browser/inlineChatLivePreviewWidget.js:180:68)
    at InlineChatLivePreviewWidget._renderChangesWithFullDiff (vscode-file://vscode-app/Users/jrieken/Code/_collab/vscode2/out/vs/workbench/contrib/inlineChat/browser/inlineChatLivePreviewWidget.js:141:33)
    at InlineChatLivePreviewWidget._updateFromChanges (vscode-file://vscode-app/Users/jrieken/Code/_collab/vscode2/out/vs/workbench/contrib/inlineChat/browser/inlineChatLivePreviewWidget.js:135:22)
    at InlineChatLivePreviewWidget.show (vscode-file://vscode-app/Users/jrieken/Code/_collab/vscode2/out/vs/workbench/contrib/inlineChat/browser/inlineChatLivePreviewWidget.js:117:18)
    at LivePreviewStrategy.renderChanges (vscode-file://vscode-app/Users/jrieken/Code/_collab/vscode2/out/vs/workbench/contrib/inlineChat/browser/inlineChatStrategies.js:315:38)
    at InlineChatController.SHOW_RESPONSE (vscode-file://vscode-app/Users/jrieken/Code/_collab/vscode2/out/vs/workbench/contrib/inlineChat/browser/inlineChatController.js:553:38)
    at InlineChatController._nextState (vscode-file://vscode-app/Users/jrieken/Code/_collab/vscode2/out/vs/workbench/contrib/inlineChat/browser/inlineChatController.js:168:50)
    at async UniqueContainer.value (vscode-file://vscode-app/Users/jrieken/Code/_collab/vscode2/out/vs/workbench/contrib/inlineChat/browser/inlineChatController.js:90:17)

@jrieken jrieken added this to the September 2023 milestone Sep 12, 2023
@jrieken
Copy link
Member

jrieken commented Sep 12, 2023

@tuduongquyet please still check and share logs, it is still possible that you are facing a completely different issue

jrieken added a commit to microsoft/vscode that referenced this issue Sep 13, 2023
@jrieken jrieken changed the title Floating Code Chat Window Can't Be Closed InlineChat Can't Be Closed Sep 13, 2023
lins0621 pushed a commit to lins0621/vscode that referenced this issue Sep 14, 2023
@jrieken jrieken modified the milestones: September 2023, October 2023 Sep 25, 2023
@SiyabongaCyril
Copy link

I am facing the same issue.
Github Copilot Chat version: v0.7.1
Visual Studio Code version: 1.82.3
The inline chat does not appear to have a close button. Cancel only appears after making a request, and is able to close the inline chat window.

@jrieken jrieken modified the milestones: October 2023, November 2023 Oct 23, 2023
@jrieken jrieken closed this as completed Nov 27, 2023
@jrieken jrieken modified the milestones: November 2023, December 2023 Nov 27, 2023
@jrieken jrieken reopened this Nov 27, 2023
@jrieken jrieken closed this as completed Dec 8, 2023
@roblourens roblourens modified the milestones: December 2023/January 2024, December / January 2024 Dec 14, 2023
@amunger amunger added the verified Verification succeeded label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug inline-chat Inline editor chat session UI verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants