-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improve error-handling of mongo shell #1148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally a bit wary of all the debounce
, setTimeout
, etc. code in InteractiveChildProcess (what does await delay(0)
even do??) but looks good overall so far. Will wait to do a more thorough review until you say it's ready.
Yeah, not happy about it, either, am open to suggestions. setTimeout(fn, 0) is essentially "execute on next event loop" in Node.js (http://voidcanvas.com/setimmediate-vs-nexttick-vs-settimeout/ - overly complicated). Shouldn't matter what delay I use, I just have to give the stream time to process. |
Close to finished, sending up the PR early get feedback on the approach. Ideally I'd like to write some tests, too. Rewrote shell.ts completely from scratch after Eric's comments from previous PR.
Fixes #838
Also fixes #1104
Possibly fixes error reporting for:
#1071
#988
#852
#820
#794
#1092
Testcases in OneNote:
![image](https://user-images.githubusercontent.com/6913354/57112768-5b3d2800-6cf6-11e9-98dd-616f8af3ccb7.png)