Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect intelliSenseMode selected by cpptools when unspecified #8044

Closed
bobbrow opened this issue Aug 24, 2021 · 4 comments
Closed

Incorrect intelliSenseMode selected by cpptools when unspecified #8044

bobbrow opened this issue Aug 24, 2021 · 4 comments
Assignees
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense Feature: Extension API fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix

Comments

@bobbrow
Copy link
Member

bobbrow commented Aug 24, 2021

We've been having issues with architecture in CMake Tools, and while investigating some issues, I discovered this problem. CMake Tools doesn't send the intelliSenseMode anymore because cpptools is supposed to figure it out, but when CMake Tools sends the path to an MSVC compiler that targets x86, cpptools selects the 64-bit intelliSenseMode.

Bolding for emphasis here since the Markdown won't let me do that in a code block:
c:/program files (x86)/microsoft visual studio/2019/preview/vc/tools/msvc/14.29.30133/bin/hostx86/x86/cl.exe

Custom configurations:
[ D:\test\cmaketest\main.cpp ]
{
    "defines": [
        "WIN32",
        "_WINDOWS"
    ],
    "includePath": [],
    "compilerPath": "c:/program files (x86)/microsoft visual studio/2019/preview/vc/tools/msvc/14.29.30133/bin/hostx86/x86/cl.exe",
    "compilerArgs": [
        "/DWIN32",
        "/D_WINDOWS",
        "/GR",
        "/EHsc",
        "/Zi",
        "/Ob0",
        "/Od",
        "/RTC1",
        "-MDd"
    ]
}
Translation Unit Mappings:
[ D:\test\cmaketest\main.cpp ]:
    D:\TEST\CMAKETEST\MAIN.CPP
Translation Unit Configurations:
[ D:\test\cmaketest\main.cpp ]:
    Process ID: 10944
    Memory Usage: 16 MB
    Compiler Path: c:/program files (x86)/microsoft visual studio/2019/preview/vc/tools/msvc/14.29.30133/bin/hostx86/x86/cl.exe
    Includes:
        C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2019\PREVIEW\VC\TOOLS\MSVC\14.29.30133\INCLUDE
        C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2019\PREVIEW\VC\TOOLS\MSVC\14.29.30133\ATLMFC\INCLUDE
        C:\PROGRAM FILES (X86)\WINDOWS KITS\10\INCLUDE\10.0.19041.0\UM
        C:\PROGRAM FILES (X86)\WINDOWS KITS\10\INCLUDE\10.0.19041.0\UCRT
        C:\PROGRAM FILES (X86)\WINDOWS KITS\10\INCLUDE\10.0.19041.0\SHARED
        C:\PROGRAM FILES (X86)\WINDOWS KITS\10\INCLUDE\10.0.19041.0\WINRT
        C:\PROGRAM FILES (X86)\WINDOWS KITS\10\INCLUDE\10.0.19041.0\CPPWINRT
    Defines:
        WIN32
        _WINDOWS
        WIN32
        _WINDOWS
    Standard Version: ms_c++14
    IntelliSense Mode: windows-msvc-x64
    Other Flags:
        --rtti
@bobbrow bobbrow added bug Feature: Configuration An issue related to configuring the extension or IntelliSense Feature: Extension API Language Service labels Aug 24, 2021
@bobbrow
Copy link
Member Author

bobbrow commented Aug 24, 2021

It's possible this is a general issue and doesn't need to involve the configuration provider at all.

@sean-mcmanus
Copy link
Collaborator

Yeah, I don't believe we have ever looked at the compilerPath for cl.exe in determining the IntelliSense mode.

@michelleangela
Copy link
Contributor

Yeah, I don't believe we have ever looked at the compilerPath for cl.exe in determining the IntelliSense mode.

The compilerPath of cl.exe hasn't been used to determine IntelliSense mode.

@bobbrow bobbrow added this to the 1.7.0 milestone Sep 7, 2021
@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label Sep 28, 2021
@sean-mcmanus sean-mcmanus modified the milestones: 1.7.0, 1.7.0-insiders2 Sep 29, 2021
@Colengms
Copy link
Collaborator

This should be fixed in 1.7.0.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense Feature: Extension API fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
None yet
Development

No branches or pull requests

4 participants