Cherry-picks for 1.20.2 #12235
Merged
Cherry-picks for 1.20.2 #12235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… messaging for env and delimited paths under include paths in c_cpp_properties.json (#12188) * remove redundant variable resolution * fix lint * remove resolveVariable redundancies * change when resolve and split happens * fix lint * Resolve error checking for environment vars and delimited paths * remove "path" from error messaging * Adjust error messaging * remove stray comment * refactor error messaging + minor fix * resolve lint * Fix multi path squiggle regression * Remove resolvedPath redundancies * Refactor error messaging and squiggling * Revert and improve error squiggling behavior * fix linting * properly proccess glob patterns + minor fixes * fix comment positions * Refactor error message + minor fix * Fix telemetry metric + minor fix
* rename the property again * fail
* Update changelog
Colengms
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.