Import mdn/browser-compat-data. Fix #102 #105
Conversation
build/generate_browserjs.js
Outdated
|
|
||
| var { buildPropertiesWithMDNData } = require('./mdn-data-importer') | ||
| const { buildPropertiesWithMDNData } = require('./mdn-data-importer') | ||
| const { addBCPDataToProperties } = require('./mdn-browser-compat-data-importer') |
There was a problem hiding this comment.
Yeah it should be BCD. Thanks.
| * } | ||
| * } => "FF6" | ||
| */ | ||
| function supportToShortCompatString(support, browserAbbrev) { |
There was a problem hiding this comment.
This doesn't completely handle cases with more complex data, for example when a feature is behind a flag this would think it's supported:
{
"support": {
"chrome": [
{
"version_added": "67",
"flags": [
{
"type": "preference",
"name": "Enable Experimental Web Platform Features",
"value_to_set": "true"
}
]
}
]
}
}Or when a feature was removed:
{
"support": {
"firefox": [
{
"version_added": "51",
"version_removed": "54"
}
]
}
}Maybe acceptable for an MVP, not sure :)
There was a problem hiding this comment.
@connorshea I opened #107 for that.
| function addBrowserCompatDataToProperties(atdirectives, pseudoclasses, pseudoelements, properties) { | ||
| atdirectives.forEach(item => { | ||
| if (bcd.css['at-rules'][item.name.slice(1)]) { | ||
| const matchingBCPItem = bcd.css['at-rules'][item.name.slice(1)] |
There was a problem hiding this comment.
there's also a bunch of BCP in this file :)
There was a problem hiding this comment.
@connorshea You are right. Originally wanted to call it browser-compat-property.
octref
changed the title
|
@aeschli I updated the PR to use One thing I left out is dropping Opera. browser-compat-data also has data for mobile browser supports such as Safari iOS, FF Android, etc. However I don't want to include all browser compat data to clutter the completion item's doc. |
mdn/browser-compat-dataas a dev dependencyCosmetics:
/buildthe same style