Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unknown at rules. Fix #51 #106

Merged
merged 5 commits into from
Jun 18, 2018
Merged

Conversation

octref
Copy link
Contributor

@octref octref commented Jun 14, 2018

Known limitations:

Removed a test case from 7f07d5e which intended to address microsoft/vscode#2573 and microsoft/vscode#23862

Currently the parser rule is relaxed, so

// .something {
    @media (max-width: 760px) {
        > .test {
            color: blue;
        }
    }
// }

Will not give any errors, although > .test inside @media should really be used in a nested selector.

Did this because the current errors for this case is very wrong:

wrong

@aeschli I can log a new issue for giving correct error here, like Selectors that begin with a combinator should be used inside a nested RuleSet.

@octref octref merged commit 4aaa9e2 into master Jun 18, 2018
@octref octref deleted the octref/scss-unknown-at-rules branch June 18, 2018 22:45
@aeschli aeschli added this to the June 2018 milestone Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants