Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'processEvent' to debug protocol #124

Merged
merged 1 commit into from Jul 25, 2017

Conversation

gregg-miskelly
Copy link
Member

This defines a new 'processEvent' to resolve #122

This defines a new 'processEvent' to resolve microsoft#122
@msftclas
Copy link

@gregg-miskelly,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@gregg-miskelly
Copy link
Member Author

@andrewcrawley
Copy link
Contributor

LGTM. When would isLocalProcess be false? Every "remote" scenario I'm aware of has the machine boundary between the UI and the debug adapter, not between the DA and the debuggee.

@gregg-miskelly
Copy link
Member Author

gregg-miskelly commented Jul 24, 2017

@andrewcrawley -- I would expect that debug adapters that are remoted themselves should probably not set this at all (unless they are aware of when they are being remoted). The one place I was expecting to use this was in vsdbg-ui since it is always local and could give the IDE which is talking to it information about if the process was local or not.

@DavidKarlas
Copy link
Member

LGTM

@weinand
Copy link
Contributor

weinand commented Jul 25, 2017

FYI: Debug adapters cannot run remote because the DAP uses local file paths, so there is an assumption that they run side by side with the frontend/client and they have access to the workspace.
It would be possible to remove this assumption (by changing the DAP), but this would be a breaking change.

@weinand weinand merged commit df75d57 into microsoft:master Jul 25, 2017
@weinand
Copy link
Contributor

weinand commented Jul 25, 2017

@gregg-miskelly Perfect! Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugee PID is not available to IDE
5 participants