updating per code review feedback

microsoft · Apr 17, 2019 · 3482157 · 3482157
1 parent bf3cf07
commit 3482157
Show file tree

Hide file tree

Showing 28 changed files with 11 additions and 334 deletions.
diff --git a/containers/python-3-anaconda/.devcontainer/devcontainer.json b/containers/python-3-anaconda/.devcontainer/devcontainer.json
@@ -1,7 +1,8 @@
 {
-	"name": "Anaconda 3",
-	"dockerComposeFile": "docker-compose.yml",
-	"service": "app",
+	"name": "Python 3 - Anaconda",
+	"context": "..",
+	"dockerFile": "Dockerfile",
+	"appPort": "5000:5000",
 	"workspaceFolder": "/workspace",
 	"extensions": [
 		"ms-python.python",

diff --git a/containers/python-3-anaconda/.devcontainer/docker-compose.yml b/containers/python-3-anaconda/.devcontainer/docker-compose.yml
diff --git a/containers/python-3-flask-redis/.devcontainer/Dockerfile b/containers/python-3-flask-redis/.devcontainer/Dockerfile
diff --git a/containers/python-3-flask-redis/.devcontainer/devcontainer.json b/containers/python-3-flask-redis/.devcontainer/devcontainer.json
diff --git a/containers/python-3-flask-redis/.devcontainer/docker-compose.yml b/containers/python-3-flask-redis/.devcontainer/docker-compose.yml
diff --git a/containers/python-3-flask-redis/.devcontainer/requirements.txt b/containers/python-3-flask-redis/.devcontainer/requirements.txt
diff --git a/containers/python-3-flask-redis/.devcontainer/settings.vscode.json b/containers/python-3-flask-redis/.devcontainer/settings.vscode.json
diff --git a/containers/python-3-flask-redis/.npmignore b/containers/python-3-flask-redis/.npmignore
diff --git a/containers/python-3-flask-redis/.vscode/launch.json b/containers/python-3-flask-redis/.vscode/launch.json
diff --git a/containers/python-3-flask-redis/.vscode/settings.json b/containers/python-3-flask-redis/.vscode/settings.json
diff --git a/containers/python-3-flask-redis/README.md b/containers/python-3-flask-redis/README.md
diff --git a/containers/python-3-flask-redis/test-project/Dockerfile b/containers/python-3-flask-redis/test-project/Dockerfile
diff --git a/containers/python-3-flask-redis/test-project/app.py b/containers/python-3-flask-redis/test-project/app.py
diff --git a/containers/python-3-flask-redis/test-project/docker-compose.yml b/containers/python-3-flask-redis/test-project/docker-compose.yml
diff --git a/containers/python-3-flask-redis/test-project/requirements.txt b/containers/python-3-flask-redis/test-project/requirements.txt
diff --git a/containers/python-3-jupyter-pyspark/.devcontainer/Dockerfile b/containers/python-3-jupyter-pyspark/.devcontainer/Dockerfile
diff --git a/containers/python-3-jupyter-pyspark/.devcontainer/devcontainer.json b/containers/python-3-jupyter-pyspark/.devcontainer/devcontainer.json
diff --git a/containers/python-3-jupyter-pyspark/.devcontainer/docker-compose.yml b/containers/python-3-jupyter-pyspark/.devcontainer/docker-compose.yml
diff --git a/containers/python-3-jupyter-pyspark/.devcontainer/jupyter_notebook_config.py b/containers/python-3-jupyter-pyspark/.devcontainer/jupyter_notebook_config.py
diff --git a/containers/python-3-jupyter-pyspark/.devcontainer/settings.vscode.json b/containers/python-3-jupyter-pyspark/.devcontainer/settings.vscode.json
diff --git a/containers/python-3-jupyter-pyspark/.npmignore b/containers/python-3-jupyter-pyspark/.npmignore
diff --git a/containers/python-3-jupyter-pyspark/.vscode/settings.json b/containers/python-3-jupyter-pyspark/.vscode/settings.json
diff --git a/containers/python-3-jupyter-pyspark/README.md b/containers/python-3-jupyter-pyspark/README.md
diff --git a/containers/python-3-jupyter-pyspark/test-project/notebook.py b/containers/python-3-jupyter-pyspark/test-project/notebook.py
diff --git a/containers/python-3-miniconda/.devcontainer/devcontainer.json b/containers/python-3-miniconda/.devcontainer/devcontainer.json
@@ -1,7 +1,8 @@
 {
-	"name": "Miniconda 3",
-	"dockerComposeFile": "docker-compose.yml",
-	"service": "app",
+	"name": "Python 3 - Miniconda",
+	"context": "..",
+	"dockerFile": "Dockerfile",
+	"appPort": "5000:5000",
 	"workspaceFolder": "/workspace",
 	"extensions": [
 		"ms-python.python",

diff --git a/containers/python-3-miniconda/.devcontainer/docker-compose.yml b/containers/python-3-miniconda/.devcontainer/docker-compose.yml
diff --git a/containers/python-3/.devcontainer/devcontainer.json b/containers/python-3/.devcontainer/devcontainer.json
@@ -1,7 +1,8 @@
 {
 	"name": "Python 3",
-	"dockerComposeFile": "docker-compose.yml",
-	"service": "app",
+	"context": "..",
+	"dockerFile": "Dockerfile",
+	"appPort": "5000:5000",
 	"workspaceFolder": "/workspace",
 	"extensions": [
 		"ms-python.python",

diff --git a/containers/python-3/.devcontainer/docker-compose.yml b/containers/python-3/.devcontainer/docker-compose.yml