.gitconfig file not copied when setting safe.directory via postCreateCommand

[HenrikStanley]

• VSCode Version: 1.69.1
• Local OS Version: Windows 11 Pro, OS Build 22000.795
• Local chip architecture: x86
• Reproduces in: Remote - Containers
• Name of Dev Container Definition with Issue: Custom Container Image

Using a custom made container image, the VSCode setting for copying the .gitconfig file from the host does not work when editing the .gitconfig file via postCreateCommand.

This seems to be due to the check for existing .gitconfig files happening after running:
git config --global --add safe.directory ${containerWorkspaceFolder}

as part of the postCreateCommand steps.

Steps to Reproduce:

1. Set Remote › Containers: Copy Git Config setting to true
2. Set in devcontainer.json git config --global --add safe.directory ${containerWorkspaceFolder}

Suggested solutions:

• Run the copy of gitconfig from host before postCreateCommand.
• Add a setting natively in devcontainer.json or the vscode plugin to add add safe.directorys at the appropriate timing after copy from host.

[bamurtaugh]

Thanks for opening, @HenrikStanley.

@joshspicer @edgonmsft does this sound like a spec issue (so it should be moved to https://github.com/devcontainers/spec)? Or specific to Remote-Containers (so it should be moved to https://github.com/microsoft/vscode-remote-release)?

[edgonmsft]

I think it would be a cli issue

[bamurtaugh]

Thanks @edgonmsft.

@HenrikStanley if you're still experiencing this, would you be able to open an issue in https://github.com/devcontainers/cli/issues instead? Thanks!

[HenrikStanley]

@bamurtaugh

I have submitted an issue in the CLI repository and updated the issue a bit to make it clearer.
Thanks for the guidance.

(I will close this issue and leave a link here for the new one):
devcontainers/cli#98