Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Don't run pip install -r requirements.txt in the Dockerfile #111

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Don't run pip install -r requirements.txt in the Dockerfile #111

merged 1 commit into from
Aug 2, 2019

Conversation

brettcannon
Copy link
Member

Instead, make it a suggested postCreateCommand.

@brettcannon
Don't run pip install -r requirements.txt in the Dockerfile
449d324 
Instead, make it a suggested postCreateCommand.
@brettcannon brettcannon requested a review from Chuxel August 1, 2019 23:08
Chuxel
Chuxel approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@Chuxel Chuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brettcannon brettcannon merged commit 58b60f9 into microsoft:master Aug 2, 2019
@brettcannon brettcannon deleted the no-requirements-in-image branch August 2, 2019 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Chuxel Chuxel Chuxel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brettcannon @Chuxel