-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove noop.txt in the python-2 and python-3-posgres folder?
Also, the root requirements.txt in the root of python-3-posgres can probably be deleted too, correct? The test project could do a preLaunchCommand to install requirements.txt if needed. The main reason that file was there was because it got built into the image.
Otherwise LGTM
@Chuxel you're correct about the As for the |
But that doesn't actually get used now on build does it? What we've done for things like node is add a preLaunchTask in launch.json that runs yarn install. Here this could be: .vscode/tasks.json
.vscode/launch.json
test-project/requirements.txt
|
@Chuxel Correct, |
@brettcannon Yeah I think that probably makes sense. We’ve had people ask why requirements.txt is in the root before. |
@Chuxel PTAL |
@brettcannon LGTM! |
Bring the non-conda containers all in sync in regards to not running pip during container creation and updating their
devcontainer.json
for Pylint. For conda containers, just updatedevcontainer.json
.