Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Add Tomcat 8.5 container definition #21

Merged
merged 2 commits into from
Apr 28, 2019
Merged

Add Tomcat 8.5 container definition #21

merged 2 commits into from
Apr 28, 2019

Conversation

testforstephen
Copy link
Collaborator

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Copy link
Member

@Chuxel Chuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also call this folder java-8-tomcat-8 unless there is a specific reason to stay with 8.5 instead of 8 generally. (Otherwise it would be java-8-tomcat-8.5 ... and other names would be the same.)

containers/tomcat-8.5/.devcontainer/Dockerfile Outdated Show resolved Hide resolved
containers/tomcat-8.5/README.md Outdated Show resolved Hide resolved
@Chuxel Chuxel requested a review from chrmarti April 27, 2019 13:25
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@Chuxel
Copy link
Member

Chuxel commented Apr 28, 2019

@testforstephen Is there any way to specify the path of the tomcat sever installed in the container from settings.json?

One of the things we hit was that there were a few people who had a Java path set in their local settings.json. This can be overridden with a container specific settings file.

Here's the tweak we had to make to the Java 8/11/12 definition:

# Copy endpoint specific user settings into container to specify Java path
COPY settings.vscode.json /root/.vscode-remote/data/Machine/settings.json

And .devcontainer/settings.vscode.json looked like this (except for java-12 which had a different home path):

{
    "java.home": "/docker-java-home"
}

We could add this in along with the setting for the Tomcat install path if that is an option.

@testforstephen
Copy link
Collaborator Author

Tomcat has similar environment variable CATALINA_HOME as JAVA_HOME, but the tomcat extension adashen.vscode-tomcat doesn't take use of it, no related VS Code user settings.

To run your application in Tomcat Server, you must invoke the command "Tomcat: Add Tomcat Server" firstly to add a tomcat server from your specified installation path.

@Chuxel Chuxel merged commit 2fc9469 into microsoft:master Apr 28, 2019
@testforstephen testforstephen deleted the jinbo_tomcat8.5 branch April 28, 2019 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants