This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
[Non-blocking cosmetic fix] Add missing "&&" into Node definitions when updating yarn #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the node definitions clear out the
/opt/yarn
location in the base node images and installyarn
usingapt-get
so it can be upgraded in-place by the user as needed. The code looks like this:rm -rf /opt/yarn-* \ rm -f /usr/local/bin/yarn \ rm -f /usr/local/bin/yarnpkg \ ...
This is wrong, because the last two paths won't be deleted. It should be:
rm -rf /opt/yarn-* \ && rm -f /usr/local/bin/yarn \ && rm -f /usr/local/bin/yarnpkg \ ...
However, because /opt/yarn-* is removed, the links in
/usr/local/bin
are ignored and everything works anyway. So this is more of a cosmetic fix and not blocking.