Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

[Non-blocking cosmetic fix] Add missing "&&" into Node definitions when updating yarn #28

Merged
merged 1 commit into from
May 7, 2019

Conversation

Chuxel
Copy link
Member

@Chuxel Chuxel commented May 1, 2019

Currently the node definitions clear out the /opt/yarn location in the base node images and install yarn using apt-get so it can be upgraded in-place by the user as needed. The code looks like this:

rm -rf /opt/yarn-* \
    rm -f /usr/local/bin/yarn \	   
    rm -f /usr/local/bin/yarnpkg \
    ...

This is wrong, because the last two paths won't be deleted. It should be:

rm -rf /opt/yarn-* \
    && rm -f /usr/local/bin/yarn \	   
    && rm -f /usr/local/bin/yarnpkg \
    ...

However, because /opt/yarn-* is removed, the links in /usr/local/bin are ignored and everything works anyway. So this is more of a cosmetic fix and not blocking.

@Chuxel Chuxel requested a review from chrmarti May 1, 2019 21:26
@chrmarti
Copy link
Contributor

chrmarti commented May 2, 2019

Looks good, but let's hold back on non-essential changes until we lift the lock-down.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants