This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
[java] Fix symlink and upgrade to Gradle 5.4.1 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testforstephen
approved these changes
May 5, 2019
|
@chrmarti I think this is safe to merge at this point - do you still want to hold off given its a bug fix? |
|
@brunoborges @testforstephen @chrmarti Actually I just retried and the SHA check failed. Do we need that given this will be a moving target? |
|
@Chuxel I've updated the hashes. Pls try again? |
|
LGTM! @chrmarti - LMK if you want to merge the fix. |
|
Bug fixes are good to merge. We will follow the same process as with VS Code at this point. That includes a review (can be yourself if the PR is from the community) and verification of the fixes before we publish a new version (we can download the vsix from the build). |
chrmarti
approved these changes
May 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the wrong symlink to the Gradle binary and upgrades to version 5.4.1