Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Highlight ptrace settings via commented out snippets in certain definitions #40

Merged
merged 8 commits into from
May 9, 2019

Conversation

Chuxel
Copy link
Member

@Chuxel Chuxel commented May 8, 2019

Revised version of #36

This does not directly add the different ptrace related settings required for Rust, C++, and Go, but includes them as comments in devcontainer.json and docker-compose.yml in several definitions that likely are going to be used as a base to build from.

//cc: @AntonNguyen

@Chuxel Chuxel requested a review from chrmarti May 8, 2019 23:55
@Chuxel
Copy link
Member Author

Chuxel commented May 9, 2019

@chrmarti Made those edits - Thanks! While I was in there, I also raised visibility to appPort and postCreateCommand since I've noticed on vscode-remote-release that people aren't always finding them. They're now both commented out in each devcontainer.json with a note on what they are for to try to help with that problem.

See what you think.

@chrmarti
Copy link
Contributor

chrmarti commented May 9, 2019

@Chuxel Looks good. I wonder if postCreateCommand would benefit from coming with an example. Either on the existing postCreateCommand line or on an additional line above that.

@Chuxel
Copy link
Member Author

Chuxel commented May 9, 2019

@chrmarti That's a good idea - some of the definitions like node would make that easy. Others the command could just print out the version info for the runtime. I'll still leave it commented out but it would anchor the idea. I make that edit.

@Chuxel Chuxel merged commit 30f79f4 into master May 9, 2019
"shutdownAction": "stopCompose",

// Uncomment the next line to run commands after the container is created.
// "postCreateCommand": ["uname -a"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chuxel ["uname -a"] won't work. You can use "uname -a" or ["uname", "-a"]. This is similar to CMD, RUN and others in the Dockerfile. The single string will be parsed by a shell and then executed, the array form is executed directly, without a shell.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants