Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Tweaks to Dart container #44

Merged
merged 9 commits into from
May 17, 2019
Merged

Tweaks to Dart container #44

merged 9 commits into from
May 17, 2019

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented May 17, 2019

This makes some tweaks to the Dart container:

  • Removes use of pedantic/analysis_options since it wasn't adding much but was causing lint errors at startup (due to the package not being restored before analysis)
  • Removes other unused dependencies (globally activated webdev, build_runner, build_web_compiler)
  • Removes commands for pub get (the Dart extension already has a command for this, and runs it on pubspec changes) and the instructions about it
  • Makes the browser open automatically, and removes the need to manually forward port
  • Removes unused Chrome extension
  • Move script into bin/ folder (which is the usual location for scripts like this in Dart) and unignore bin/ for the Dart folder

Based on the history, I think some of the above was because the original intention was for this to be a proper Dart web app, but it ended up becoming just a command-line app that has a HTTP listener.

I'll have a go at building a dart-web container soon too, though I need to try and resolve (or workaround) a bug that results in red squiggles not disappearing when new packages are downloaded after initial analysis (dart-lang/sdk#30845) or need to be able to run pub get prior to the package opening (which I think needs microsoft/vscode-remote-release#349).

@msftclas
Copy link

msftclas commented May 17, 2019

CLA assistant check
All CLA requirements met.

@Chuxel Chuxel self-assigned this May 17, 2019
Copy link
Member

@Chuxel Chuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan! Really appreciate the contribution! This looks great.

@Chuxel Chuxel merged commit af68070 into microsoft:master May 17, 2019
@DanTup DanTup deleted the dart-tweaks branch May 17, 2019 15:02
@DanTup
Copy link
Contributor Author

DanTup commented May 17, 2019

Great! If you have any issues with it, feel free to ping me.

I've got a Flutter one too - however it's a bit limited because you can't connect to any device or emulator (though you can run tests on the headless device :-)). It might be confusing to merge like this, so I'll do some digging to see if I can find a way to make it work (without requiring things like the Android SDK on the host!) better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants