Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Add bazel container #47

Merged
merged 10 commits into from
May 21, 2019
Merged

Add bazel container #47

merged 10 commits into from
May 21, 2019

Conversation

shikanime
Copy link
Contributor

@shikanime shikanime commented May 17, 2019 •
edited
Loading

Fixes: #43

@shikanime shikanime changed the title Ahh bazel container Add bazel container May 17, 2019
@shikanime shikanime marked this pull request as ready for review May 18, 2019 00:22
Chuxel
Chuxel approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@Chuxel Chuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition LGTM (with my limited knowledge of Bazel 😊). The test project uses C++, but I assume that extension wasn't included since Bazel supports Java as well. Is that correct?

@shikanime
Copy link
Contributor Author

shikanime commented May 21, 2019 •
edited
Loading

@Chuxel Yes that's right, Bazel natively support some language out-of-the box, including C++ and Java 🙂

@shikanime
Copy link
Contributor Author

Oh i forgot to remove some useless lines 😖

@Chuxel
Copy link
Member

Chuxel commented May 21, 2019

Thanks for the contribution!

@Chuxel Chuxel merged commit ff08887 into microsoft:master May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Chuxel Chuxel Chuxel approved these changes

Assignees

@Chuxel Chuxel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Bazel development container
2 participants
@shikanime @Chuxel