Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

add Sinatra Container #57

Merged
merged 4 commits into from
Jun 4, 2019
Merged

add Sinatra Container #57

merged 4 commits into from
Jun 4, 2019

Conversation

ricefryegg
Copy link

Add a Ruby Sinatra container with a test project.

@msftclas
Copy link

msftclas commented May 25, 2019

CLA assistant check
All CLA requirements met.

@Chuxel
Copy link
Member

Chuxel commented May 30, 2019

@Amblizer Thanks so much for the PR! Apologies for the delay looking at it. I missed it over the long weekend.

Two things:

  1. The only thing I see missing is the .npmignore file in the root of the folder. This is used to tell VS Code what to exclude when it adds the files
  2. Is port 4567 always used for Sinatra applications or is it just for the test project? If it's just the test project, we've been leaving the appPort property commented out, and then telling people to use the "Forward Port from Container..." command to test.

See the Node LTS definition for an example that includes a web based test project - you can probably just "cut-and-paste". 😊

@ricefryegg
Copy link
Author

Hi @Chuxel , thank you so much for the indication! I added the .npmignore file. The port 4567 is the default port for Sinatra, and I added a comment telling people to change it if they want to use other ones.

Have a great weekend!

@Chuxel
Copy link
Member

Chuxel commented Jun 4, 2019

LGTM! Thanks so much for the contribution.

@Chuxel Chuxel merged commit 75ab722 into microsoft:master Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants