Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Tweak Python 3 setup #93

Merged
merged 4 commits into from
Jul 3, 2019
Merged

Conversation

brettcannon
Copy link
Member

  • Drop an unnecessary * at the end of a file name for copying
  • Don't have pip bother checking for a newer version of pip (assume it's new enough as it came with the latest version of Python which the container is pulling from)
  • Don't cache wheel files (to keep the image smaller)
  • Specify the location of the pylint executable to turn on Pylint development

@Chuxel Chuxel self-assigned this Jul 3, 2019
Copy link
Member

@Chuxel Chuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment inline, but otherwise looks awesome! Thanks so much for doing it.

BTW - I gave the Python tools team write access to the repo to make merging in changes easier if Christof and I are both tied up for some reason.

containers/python-3/.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@brettcannon
Copy link
Member Author

@Chuxel which Python tools team did you give access? It's a bit nebulous as we have several teams on GitHub across us and various companion teams. 😁

@Chuxel
Copy link
Member

Chuxel commented Jul 3, 2019

@brettcannon I gave pvsc-team write access - LMK if I should use a different one.

@Chuxel
Copy link
Member

Chuxel commented Jul 3, 2019

Tested it out - LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants