Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Puppet PDK Docker Container file #94

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Jul 3, 2019

This PR adds a Puppet Development Kit docker container to VS Code Remote Container extension. It contains a Dockerfile that uses a base ruby:2 docker image and installs PDK, git, and Ruby debugging gems.

This allows a user to create and edit Puppet manifests, modules and other code without installing the PDK or other Ruby tools on their machine. The Puppet VSCode Extension is included in the defintion to provide advanced intellisense and other IDE capabilties. The Ruby VS Code extension is also included to help with editing Ruby files.

@Chuxel
Copy link
Member

Chuxel commented Jul 8, 2019

Apologies for the delay in getting back to you - the US 4th of July holiday slowed down our response times. 😊

Generally this looks great! Appreciate the contribution! The only thing I need to follow up on is that this references a Puppet license and copyright instead of the MIT license for the repo. Currently these definitions get bundled and with the Remote - Containers extension, so I need to verify that this isn't going to cause any issues. Just to verify - Is there a reason that it needs to be under the Puppet license?

@Chuxel Chuxel self-requested a review July 8, 2019 20:23
@jpogran
Copy link
Contributor Author

jpogran commented Jul 8, 2019

No reason specifically, just habit and I didn't quite understand that part of the README doesn't change. I can change and rebase.

This commit adds a [Puppet Development Kit](https://puppet.com/docs/pdk/1.x/pdk.html)
docker container to VS Code Remote Container extension. It contains a
Dockerfile that uses a base `ruby:2` docker image and installs PDK, git,
and Ruby debugging gems.

This allows a user to create and edit Puppet manifests, modules and
other code without installing the PDK or other Ruby tools on their
machine. The [Puppet VSCode Extension](https://pup.pt/vscode) is
included in the defintion to provide advanced intellisense and other IDE
capabilties. The Ruby VS Code extension is also included to help with
editing Ruby files.
@jpogran
Copy link
Contributor Author

jpogran commented Jul 8, 2019

@Chuxel modified the license line

@Chuxel
Copy link
Member

Chuxel commented Jul 8, 2019

@jpogran Thanks! Yes, we include that there just as a reference since each folder is self-contained. That way, anyone linking directly to a container README won't have to look at the repo root if they are wondering. There's a few spots in documentation where we link directly already.

@Chuxel Chuxel merged commit 7667077 into microsoft:master Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants