Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WORKDIR paths should be absolute #1492

Closed
doggy8088 opened this issue Dec 14, 2019 · 13 comments
Closed

WORKDIR paths should be absolute #1492

doggy8088 opened this issue Dec 14, 2019 · 13 comments

Comments

@doggy8088
Copy link

  1. F1 > Docker: Add Docker Files to Workspace
  2. ASP․NET Core

The generated Dockerfile has an error on WORKDIR "/src/.". See below:

image

I have to remove double quote manually to remove the warning.

image

Is this kind of bug in vscode-docker?

@rcjsuen
Copy link
Contributor

rcjsuen commented Dec 15, 2019

@doggy8088 This is an issue with the linter where it isn't taking the quotation marks into account correctly. I have opened rcjsuen/dockerfile-utils#67 to track this.

Thank you for your bug report and have a great day!

@doggy8088
Copy link
Author

@rcjsuen Thanks!

@bwateratmsft
Copy link
Contributor

bwateratmsft commented Feb 11, 2020

@rcjsuen Would we need a new version of dockerfile-utils published to consume the fix in rcjsuen/dockerfile-utils@11ef5d2?

And/or dockerfile-language-server-nodejs?

@rcjsuen
Copy link
Contributor

rcjsuen commented Feb 11, 2020

@bwateratmsft You'll need a new version of the language server to get the fix. When are you planning to cut a new release?

@bwateratmsft
Copy link
Contributor

The powers that be tell me sometime in the next couple weeks. @BigMorty to keep me honest.

@BigMorty
Copy link
Member

We are actually planning a small release fairly soon, how soon could we integrate a new version of the language server with this fix? Otherwise the next release will be a number weeks out; we don't have a specific date at this time.

@rcjsuen
Copy link
Contributor

rcjsuen commented Feb 11, 2020

@BigMorty The size of the pull request is often rather miniscule (as the change is really a simple change to the package.json file). Let me tie up some loose ends and then I'll push out a new release for you.

@rcjsuen
Copy link
Contributor

rcjsuen commented Feb 13, 2020

@bwateratmsft @BigMorty Opened #1619 to upgrade the language server.

@bwateratmsft
Copy link
Contributor

Should be fixed now by #1619.

@bwateratmsft
Copy link
Contributor

Verified this is fixed.

@BigMorty
Copy link
Member

@bwateratmsft, I assume we will integrate the new language server in our next major release?

@bwateratmsft
Copy link
Contributor

@BigMorty Yep!

@bwateratmsft
Copy link
Contributor

The fix for this is now available in Docker extension version 1.0.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants