Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade language server version to 0.0.22 #1619

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented Feb 13, 2020

This pull request updates the language server to the newly released version 0.0.22. This update helps fix #1337 and #1492.

Otherwise, there aren't a lot of big changes here outside of newly added support for the --platform flag in FROM instructions which was introduced in Docker CE 18.04. However, judging by the fact that no one ever reported this, this clearly doesn't bother anyone here.

Please use the Dockerfile below to compare the before/after behaviours.

# escape=\
# escape=\
# declaring the escape parser directive two times will now be flagged as an error

# invoke code completion between FROM and scratch,
# you'll get the new --platform flag suggested
FROM       scratch

# hover over the --platform flag to get documentation
FROM --platform=arm64 scratch

# scratch is incorrectly flagged as an error
FROM --platform=arm64 scratch

# this incorrect PLATFORM flag name will be flagged as an error
# as it must be lowercase
FROM --PLATFORM= alpine

# this WORKDIR argument used to be a warning because of the quotes, see #1492
# https://github.com/microsoft/vscode-docker/issues/1492
WORKDIR "/src/."

# invoke code completion after the : to get Docker tag suggestions, see #1337
# https://github.com/microsoft/vscode-docker/issues/1337
FROM store/intersystems/iris-community:

This update also fixes a very, very obscure bug that you can replicate with the Dockerfile below. If you have this file open and use the "Output" panel to look at the logs of the "Dockerfile Language Server", you should see some errors. Feel free to take a look at rcjsuen/dockerfile-ast#66 if you are interested in the details (though as aforementioned it is very much an edge case that I don't expect the average user to encounter).

RUN alpin\
e

This update includes updates to the server to support the --platform
flag for FROM instructions. It also resolves a few issues that were
discovered by the users of the VS Code Docker extension.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@rcjsuen rcjsuen requested a review from a team as a code owner February 13, 2020 03:29
Copy link
Contributor

@philliphoff philliphoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@bwateratmsft
Copy link
Contributor

I'll complete this now, since we have already forked for 0.10.1.

@bwateratmsft bwateratmsft merged commit d24d129 into microsoft:master Feb 14, 2020
@rcjsuen rcjsuen deleted the lsp-0.0.22 branch February 14, 2020 15:22
@rcjsuen
Copy link
Contributor Author

rcjsuen commented Feb 14, 2020

Thank you @philliphoff for reviewing and @bwateratmsft for merging.

Apologies for not getting this in sooner for your 0.10.1 release.

@bwateratmsft
Copy link
Contributor

No worries! We kinda preferred to save it for 0.11.0; we're reluctant to do dependency updates in minor releases.

@rcjsuen
Copy link
Contributor Author

rcjsuen commented Feb 14, 2020

No worries! We kinda preferred to save it for 0.11.0; we're reluctant to do dependency updates in minor releases.

Makes sense. Better safe than sorry. Have a nice day!

@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FROM image suggestions from store
3 participants