Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac and Windows activation time is higher in 1.14.0 #3054

Closed
bwateratmsft opened this issue Jul 12, 2021 · 8 comments · Fixed by #3089 or #3109
Closed

Mac and Windows activation time is higher in 1.14.0 #3054

bwateratmsft opened this issue Jul 12, 2021 · 8 comments · Fixed by #3089 or #3109

Comments

@bwateratmsft
Copy link
Contributor

bwateratmsft commented Jul 12, 2021

(Title)

Both Mac and WIndows activation time spiked significantly in 1.14.0. Doesn't seem to have occurred in Linux.

In the image, yellow line is Windows activation, purple is Mac.

image

@bwateratmsft
Copy link
Contributor Author

This regression is also visible in the Kensho dashboards.

@bwateratmsft
Copy link
Contributor Author

I have a new theory. Looking at the Kensho dashboard, it doesn't really look like the perf spike happened on the 21st (when 1.14.0 was released). It looks like it happened on the 23rd (when Docker Desktop 3.5.0 was released).

Additionally, the fact that it's affecting Mac and Windows but not Linux inclines me to believe this is a perf regression in Docker Desktop.

@bwateratmsft
Copy link
Contributor Author

Aha yep, it is Docker Desktop 3.5.0, but not a regression. There's a new default context added called "desktop-linux" that's always present.

@bwateratmsft
Copy link
Contributor Author

I ran some tests comparing the time it takes to fetch context from the gRPC daemon vs. the CLI. The daemon takes in the neighborhood of 175-200 ms to return, whereas the CLI takes about 400 ms each. This is a clear improvement but still isn't anywhere near as good as not needing to do either...

@karolz-ms
Copy link
Contributor

@bwateratmsft that is true. On the other hand it cuts the activation time in half. I'd say go for it for now, while engaging Docker and searching for a better solution.

@bwateratmsft
Copy link
Contributor Author

Do we want to drop support for older versions than work for this, or fall back on the CLI?

@karolz-ms
Copy link
Contributor

As discussed offline, we will probably have to fall back to CLI, since for Linux it is not a given that the SDK support will be installed.

@bwateratmsft
Copy link
Contributor Author

A fix for this has been released in Docker extension version 1.16.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants