Remove experiment for context lookup #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early results show that the API lookup is a clear winner. It is much faster on Windows, marginally faster on Mac, and a teeny bit slower on Linux but not enough to care (especially since, over time, Linux should be getting the daemon more broadly).
I expected the context load to be slower in cases where the API was not present--it adds the time to load that code and call the API. This does appear to be the case from the data, but is less prevalent than I expected--Mac is faster even up through the 90th percentile (as in, for at least 90% of users, this change helps) and Windows is faster up through the 95th percentile. Linux is a bit slower at the 90th percentile, but is just as fast at the 75th percentile.
This code removes the experimentation component and will always try the API lookup before a CLI lookup. Reverts part of #3102. Related to #3054.