Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use default files in docker-compose #1603

Merged
merged 2 commits into from
Feb 5, 2020
Merged

use default files in docker-compose #1603

merged 2 commits into from
Feb 5, 2020

Conversation

ravipal
Copy link
Contributor

@ravipal ravipal commented Feb 4, 2020 •
edited

If the workspace container only the default docker-compose files

  1. Just one file and it is named 'docker-compose.y(a)ml'
  2. Two files docker-compose.y(a)ml and docker-compose.override.y(a)ml

then -f is not used and let the docker-compose pick these files.

Fixes #370

@ravipal ravipal requested a review from a team as a code owner February 4, 2020 20:05
karolz-ms
karolz-ms approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only suggestion would be to make it more clear for the user that files wi

src/commands/compose.ts Show resolved Hide resolved
@ravipal ravipal merged commit 3fef3bb into master Feb 5, 2020
@ravipal ravipal mentioned this pull request Feb 5, 2020
Closed
@haniamr haniamr mentioned this pull request Feb 13, 2020
Closed
@ravipal ravipal mentioned this pull request Feb 25, 2020
Closed
@bwateratmsft bwateratmsft deleted the ravipal/compose-with-nofiles branch May 7, 2020 17:58
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kzadora kzadora kzadora left review comments

@philliphoff philliphoff philliphoff approved these changes

@karolz-ms karolz-ms karolz-ms approved these changes

Assignees

@haniamr haniamr

@philliphoff philliphoff

@karolz-ms karolz-ms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compose - Don't prompt if only one yml file in CWD
5 participants
@ravipal @philliphoff @kzadora @karolz-ms @haniamr