Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use resolved definition for custom execution #2250

Merged
merged 4 commits into from Sep 11, 2020
Merged

Use resolved definition for custom execution #2250

merged 4 commits into from Sep 11, 2020

Conversation

bwateratmsft
Copy link
Contributor

Fixes #1413, fixes #1961.

@bwateratmsft bwateratmsft requested a review from a team as a code owner August 25, 2020 15:30
karolz-ms
karolz-ms approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the reference changes are the only remaining changes, LGTM!

@bwateratmsft bwateratmsft mentioned this pull request Aug 25, 2020
Closed
@bwateratmsft bwateratmsft merged commit f1f06a9 into master Sep 11, 2020
@bwateratmsft bwateratmsft deleted the bmw/resolved branch September 11, 2020 13:16
@bwateratmsft bwateratmsft mentioned this pull request Sep 14, 2020
Closed
@bwateratmsft bwateratmsft linked an issue Sep 22, 2020 that may be closed by this pull request
[Suggestion] Change the oldest VS Code version that the Docker extension supported #2309
Closed
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
@bwateratmsft @Dmarch28
Use resolved definition for custom execution (microsoft#2250)
5daf9df
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karolz-ms karolz-ms karolz-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bwateratmsft @karolz-ms