Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HEAD request to get digest #2691

Merged
merged 2 commits into from Feb 4, 2021
Merged

Use HEAD request to get digest #2691

merged 2 commits into from Feb 4, 2021

Conversation

bwateratmsft
Copy link
Contributor

@bwateratmsft bwateratmsft commented Feb 1, 2021

This change does several things:

  1. Uses the Accept: application/vnd.docker.distribution.manifest.list.v2+json header to enable doing HEAD requests--not subject to rate limiting--to check if an image is out-of-date
  2. Re-enables out-of-date checking by default
  3. Returns out-of-date checking to once per session instead of once per day. I don't feel strongly that it ought to be once-per-session, so if desired I can keep it at once-per-day.

I'd be OK with putting this in either 1.10.0 or 1.11.0.

@bwateratmsft bwateratmsft requested a review from a team as a code owner February 1, 2021 19:12
@bwateratmsft bwateratmsft merged commit c040cc8 into main Feb 4, 2021
@bwateratmsft bwateratmsft deleted the bmw/outdated branch February 4, 2021 15:06
@bwateratmsft bwateratmsft added this to the 1.10.0 milestone Feb 4, 2021
@BigMorty
Copy link
Member

BigMorty commented Feb 9, 2021

This is great news!!! I am OK with once a day also.

@bwateratmsft
Copy link
Contributor Author

This is now released in Docker extension version 1.10.0.

Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
* Use HEAD request to get digest

* Don't flag none-tagged
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants