Include different delimiter for Date #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philliphoff
approved these changes
Feb 7, 2022
|
@left-code what does the date field look like on German localization? |
@bwateratmsft It's in format Maybe my solution won't work for all localization, but I would say that dot delimiter is pretty common in Europe. |
bwateratmsft
approved these changes
Feb 8, 2022
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
|
Everything looks good, thanks for the contribution @left-code! |
|
This is now released in Docker extension version 1.20.0. Thanks for your contribution @left-code! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case that Windows container is created with different localization function
parseWindowsDirectoryItemswon't return any folder.Tested on container created using German localization.