Add diagnostic logging option to help with advanced troubleshooting #3809

danegsta · 2023-01-24T23:49:38Z

No description provided.

karolz-ms

Looks great. Just one small suggestion for better code readability.

src/extension.ts

package.json

src/extension.ts

src/runtimes/docker/utils/spawnStreamAsync.ts

src/commands/registries/logInToDockerCli.ts

Because I want to

src/extension.ts

src/utils/AzExtLogOutputChannelWrapper.ts

src/runtimes/docker/utils/spawnStreamAsync.ts

src/runtimes/clients/AutoConfigurableDockerClient.ts

src/extension.ts

src/utils/diagnostics.ts

…ogging is enabled

src/extension.ts

src/utils/diagnostics.ts

bwateratmsft

Don't forget to copy the changes upstream!

Add diagnostic logging option to help troubleshoot issues

0a3f4ab

danegsta requested a review from a team as a code owner January 24, 2023 23:49

karolz-ms previously approved these changes Jan 25, 2023

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

bwateratmsft previously requested changes Jan 25, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

bwateratmsft reviewed Jan 25, 2023

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

bwateratmsft reviewed Jan 25, 2023

View reviewed changes

src/runtimes/docker/utils/spawnStreamAsync.ts Show resolved Hide resolved

Use LogOutputChannel implementation

27fdb47

danegsta dismissed karolz-ms’s stale review via 27fdb47 January 25, 2023 21:28

bwateratmsft reviewed Jan 25, 2023

View reviewed changes

src/commands/registries/logInToDockerCli.ts Outdated Show resolved Hide resolved

bwateratmsft self-requested a review January 25, 2023 21:38

danegsta added 3 commits January 25, 2023 13:44

More diagnostic logging tweaks

52a8819

Fix linting errors

c87a24d

Remove redundant warning label from log output

8dae1c3