Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change run commands to use imageId instead of tag #4112

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Change run commands to use imageId instead of tag #4112

merged 4 commits into from
Oct 18, 2023

Conversation

jnsjunior
Copy link
Contributor

Hello,

The purpose of this pull request is to solve issue #4100 .

Unit tests:

1- Build an untagged image:

Example Dockerfile
image

Build
image

Untagged image built
image

2- Run it (interactive):

Run interactive
image

Check running
image

Check image ID
image

@jnsjunior jnsjunior requested a review from a team as a code owner October 11, 2023 14:51
bwateratmsft
bwateratmsft reviewed Oct 11, 2023
View reviewed changes
src/commands/selectCommandTemplate.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/commands/selectCommandTemplate.ts Outdated Show resolved Hide resolved
src/commands/selectCommandTemplate.ts Outdated Show resolved Hide resolved
jnsjunior and others added 2 commits October 12, 2023 13:37
@jnsjunior @alexyaang
Update src/commands/images/runImage.ts
cb58238 
Co-authored-by: Alex Yang [MSFT] <59073590+alexyaang@users.noreply.github.com>
@jnsjunior @alexyaang
Update src/commands/selectCommandTemplate.ts
cb463c8 
Co-authored-by: Alex Yang [MSFT] <59073590+alexyaang@users.noreply.github.com>
bwateratmsft
bwateratmsft approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We'll need to wait until 1.27.0 is released as we're right in the middle of a release test pass. This change can go into 1.28.0.

@bwateratmsft bwateratmsft linked an issue Oct 12, 2023 that may be closed by this pull request
Cannot run untagged image #4100
Closed
@jnsjunior
Copy link
Contributor Author

Thank you @bwateratmsft
I am happy to help this project

@bwateratmsft
Copy link
Contributor

Now that 1.27.0 is released I'll merge this. Thank you again @jnsjunior!

@bwateratmsft bwateratmsft merged commit 4a343b5 into microsoft:main Oct 18, 2023
2 checks passed
@microsoft microsoft locked and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexyaang alexyaang alexyaang left review comments

@bwateratmsft bwateratmsft bwateratmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run untagged image
3 participants
@jnsjunior @bwateratmsft @alexyaang