Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update targets to work correctly with 8.0.100-rc2 and up #4201

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

bwateratmsft
Copy link
Contributor

@bwateratmsft bwateratmsft commented Jan 10, 2024

Fixes #4199
Closes #3988 since the debugging Just Works (TM) with .NET 8 console projects as long as the EnableSdkContainerSupport property is manually set to true (e.g. in the .csproj file)

/cc @baronfel does this look about right?

@bwateratmsft bwateratmsft requested a review from a team as a code owner January 10, 2024 19:48
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a big comment for future-us.

Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>
@bwateratmsft bwateratmsft merged commit b182624 into main Jan 11, 2024
2 checks passed
@bwateratmsft bwateratmsft deleted the bmw/dotnetsdkbuild branch January 11, 2024 13:33
@microsoft microsoft locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET SDK container debugging no longer works .NET SDK Build PublishProfile Change
3 participants