64232 cleanup scripts #148
Conversation
…f parse with yaml.
| * and cleans up Yaml Metadata values that have single array items | ||
| * then converts the array to single item. | ||
| */ | ||
| function handleSingValuedMetadata() { |
| return data.replace(regex, `${variable}: ${value}`) | ||
| } | ||
| catch (error) { | ||
| console.error('Error occurred:', error); |
There was a problem hiding this comment.
I'm pretty sure it does, but when the error is logged, does it also log the line number?
| } | ||
|
|
||
| switch (selection.label.toLowerCase()) { | ||
| case "single-valued metadata": |
There was a problem hiding this comment.
Are we using typescript 2? If so we could use the readonly modifier and start moving strings like this to immutable constants.
| data = data.replace(technetRegex, "https://technet.microsoft.com") | ||
| let docsRegexLang = new RegExp(/https:\/\/docs.microsoft.com\/[A-Za-z]{2}-[A-Za-z]{2}\//g) | ||
| data = data.replace(docsRegexLang, "https://docs.microsoft.com/") | ||
| let azureRegexLang = new RegExp(/https:\/\/azure.microsoft.com\/[A-Za-z]{2}-[A-Za-z]{2}\//g) |
There was a problem hiding this comment.
The one time i've had to "undo" this is when it was embedded in sample JSON response from the translation API. Probably not worth coding around that though
docs-markdown/package.json
Outdated
| { | ||
| "command": "applyCleanup", | ||
| "group": "Docs", | ||
| "when": "vscode.extensions.getExtension('docsmsft.docs-article-templates').active" |
There was a problem hiding this comment.
I think we can change this to "resourceLangId == markdown" so it doesn't have a dependency on the templates extension.
| items.push({ | ||
| description: "", | ||
| label: "$(tasklist) Cleanup...", | ||
| }); |
There was a problem hiding this comment.
This can be moved out of the template extension check into the core quickpick menu.
Feedback - Do not merge
Thank you for the suggestion and that is an excellent Idea. I will see if we can make that happen. It would be far less intrusive to keep a markdown linter watching vs running a long process to fix everything all at once. |
|
@bharney-msft do you want me to file a separate issue? |
|
@nschonni Sounds good, please do file another issue. I like that idea. |
ghost
merged commit 
Cleanup... is accessible via the markdown extension (Alt + M) and allows the user to update metadata for each file in the working root directory/ repo. Cleanup... does 4 main things:
The scripts also touch each file in the repo and replace values. So the total time the scripts take to run/complete will vary based on the size of the repo. Any where from a few seconds to 4 minutes for the sql-docs and azure repos.