Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the “icon” option of extension commands #2220

Closed
FranklinYu opened this issue Nov 24, 2018 · 2 comments
Closed

Document the “icon” option of extension commands #2220

FranklinYu opened this issue Nov 24, 2018 · 2 comments
Assignees
Labels
extensibility extension author content under /api

Comments

@FranklinYu
Copy link

Some extension has commands with icons, such as GitLens (warning: large JSON file). Snippet of that section:

{
    "command": "gitlens.diffWithNext",
    "title": "Compare File with Next Revision",
    "category": "GitLens",
    "icon": {
        "dark": "images/dark/icon-next-commit.svg",
        "light": "images/light/icon-next-commit.svg"
    }
}

Is this documented somewhere? Current documentation seems to only cover command, title, and category.

@gregvanl gregvanl added the extensibility extension author content under /api label Nov 26, 2018
@octref
Copy link
Contributor

octref commented Nov 26, 2018

Related: #2189

@mjbvz I do think we should have a reference though. This was one of the feedback in microsoft/vscode#58226 (comment) too.

@octref octref added this to the Extensibility Backlog milestone Dec 2, 2018
@gregvanl
Copy link

https://code.visualstudio.com/api/references/contribution-points#contributes.commands does mention icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensibility extension author content under /api
Projects
None yet
Development

No branches or pull requests

4 participants