Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple guide / sample for Commands #2189

Closed
octref opened this issue Nov 15, 2018 · 5 comments
Closed

Add a simple guide / sample for Commands #2189

octref opened this issue Nov 15, 2018 · 5 comments
Assignees
Labels
extensibility extension author content under /api
Milestone

Comments

@octref
Copy link
Contributor

octref commented Nov 15, 2018

Writer: @mjbvz
Reviewer: @octref / @jrieken


Add a guide to Extension Guides / Command, and a sample at vscode-extension-samples.

@octref octref added the API documentation API reference issues label Nov 15, 2018
@octref octref added this to the November 2018 milestone Nov 15, 2018
@jrieken
Copy link
Member

jrieken commented Nov 15, 2018

don't forget

  • menus,
  • keybindings
  • when clauses
  • arguments
  • the fact that anyone can call your commands with any arguments

@octref
Copy link
Contributor Author

octref commented Nov 15, 2018

@jrieken I think you understand what the emphasis of this document should be more than I do, so adding you as a reviewer.

@gregvanl gregvanl added extensibility extension author content under /api and removed API documentation API reference issues labels Nov 15, 2018
mjbvz added a commit that referenced this issue Nov 26, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Nov 26, 2018

Fixed by e87428b

@mjbvz mjbvz closed this as completed Nov 26, 2018
@octref
Copy link
Contributor Author

octref commented Nov 26, 2018

@mjbvz Can we keep this issue open for review feedbacks?
@jrieken Please take a look.

octref added a commit that referenced this issue Nov 26, 2018
@jrieken jrieken reopened this Nov 27, 2018
@octref
Copy link
Contributor Author

octref commented Nov 30, 2018

LGTM. @jrieken if you have more feedback please open new issues.

@octref octref closed this as completed Nov 30, 2018
octref added a commit that referenced this issue Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensibility extension author content under /api
Projects
None yet
Development

No branches or pull requests

4 participants