Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y_Visual Studio Code Services_Home_Keyboard: The "Get Started" control is a link but visually it appears as a button. #5555

Closed
Yashi1201 opened this issue Aug 8, 2022 · 2 comments
Assignees
Labels
accessibility docs-experience feedback on code.visualstudio.com experience

Comments

@Yashi1201
Copy link

Yashi1201 commented Aug 8, 2022

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags:#A11yMAS;#A11yTCS;#BM_Visual Studio Code Services_Aug2022;#Visual Studio Code Services;#Win10;#FTP;#DesktopWeb;#A11ySev2;#WCAG3.2.4;#Keyboard;#Chrome;#Closed;

Environment Details:

Application Name: Visual Studio Code Services
URL: https://code.visualstudio.com/
Windows Version: Win10
Chrome Version: Version 103.0.5060.134(Official build)(64-bit)

Repro Steps:

  1. Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility tester after verification of the fix
  2. Launch the application Url : https://code.visualstudio.com/
  3. Tab till "Get Started" link.
  4. Observe that "Get Started" is a link but visually appearing as button.

Actual:

The "Get Started" control is a link but visually appears as a button. The visual appearance of this control as a button is not consistent.

Similar issue is observed in following scenario:

  1. Home_Header: The "Download" control is a link but visually it appears as a button.
  2. Docs Python_Tutorial: The "Edit" control is a link but visually it appears as a button.

Expected:

The "Get Started" control is a link and visually should also appear as a link. All links should be consistent in appearance visually.

User Impact:

Keyboard users will get confused with the control appearance as a button and function as a link.

Attachment

Get started link appearing as button visually
Similar issue Download is a link but visually appearing as button
5555_A11y_Home_Keyboard_Similar issue_Docs-Python

@Yashi1201 Yashi1201 changed the title A11y_Home_DeveloperTool: The "Get Started" is a link but visually it is appearing as button. A11y_Home_Keyboard: The "Get Started" is a link but visually it is appearing as button. Aug 8, 2022
@gregvanl gregvanl added accessibility docs-experience feedback on code.visualstudio.com experience labels Aug 8, 2022
@Yashi1201 Yashi1201 changed the title A11y_Home_Keyboard: The "Get Started" is a link but visually it is appearing as button. A11y_Visual Studio Code Services_Home_Keyboard: The "Get Started" control is a link but visually it appears as a button. Aug 10, 2022
@gregvanl
Copy link

Won't fix. Many sites including learn.microsoft.com (see image) below use buttons for links.
Closing as GitHub issue do not have a "Resolved" state.
Here the "Edit this document" button on learn.microsoft.com is a link that takes the user to the Markdown file on GitHub
image

@Yashi1201
Copy link
Author

As per discussion with SME, "If there is a link and it is visually appearing as button control then it is NAB as long as screen reader should read the correct role for it, visually they can appear as anything".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility docs-experience feedback on code.visualstudio.com experience
Projects
None yet
Development

No branches or pull requests

2 participants